255617 - Custom update.rdf ignored at installation of incompatible extension

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dorando]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.2) Gecko/20040814 Firefox/0.9.1+

I hope I got this right...

If a user tries to install an extension which is incompatible with the current
version, nsExtensionManager__getItemForID is called to generate an item (line
2273) which is later passed to nsExtensionItemUpdater_checkForUpdates (from 2287
to 2557; from 2571 to 2910;) to check for compatibility updates. The problem is
that this item is missing an updateRDF which causes Firefox to fall back to the
updateService (line 2936) instead of using the provided update.rdf.

Reproducible: Always
Steps to Reproduce:
1. Try to install an incompatible extension with a custom update.rdf.

Actual Results:  
Firefox tries to contact the updateService proxy (which isn't online yet) and
the "Incompatible Extension" dialog appears after the timeout.

Expected Results:  
The "Incompatible Extension" dialog should appear almost immediately or the
extension should install (if compatibility updates are available).

Patch follows

Comment 1

[Dorando]

Attachment: Proposed fix

Comment 2

[Asa Dotzler [:asa]]

Ben, can you take a look at this?

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Thanks. checked in. 

Comment 4

[Dorando]

Attachment: follow-up patch

So this actually works (the patch was bitrotten)...

Comment 5

[Benjamin Smedberg]

Let's get this reviewed quick.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 158231 [details] [diff] [review]
follow-up patch

r+a=[e-mail]... landing this with my patch to 258123

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Patch checked in.