255642 - about: links to nonexistent NPL

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Ryan Polk (Quark)]

from ieremiou @ http://forums.mozillazine.org/viewtopic.php?t=114045

about.xhtml (about:) has a link to the Netscape Public License at
chrome://global/content/NPL-1.1.html
However, NPL-1.1.html is neither registered in the .jar nor even in the source
(\toolkit\content\).

Comment 1

[Neil Turner]

Confirmed in 20040812 (Windows).

Comment 2

[Gervase Markham [:gerv]]

This works fine in the suite; it's just Firefox.

Gerv

Comment 3

[Blake Ross]

Steffen, can you take a look? Thanks!

Comment 4

[Steffen Wilberg]

Can we remove the reference to the NPL?
http://lxr.mozilla.org/aviarybranch/source/xpfe/global/resources/locale/en-US/about.xhtml#97

Or do we have to ship it?
I'd copy mozilla/xpfe/global/resources/content/NPL-1.1.html to toolkit/content/
and add it to toolkit/content/jar.mn then.

Comment 5

[Benjamin Smedberg]

Changes to about: affect l10n, let's make a decision and get this fixed.

Comment 6

[Gervase Markham [:gerv]]

Gerv says: ship it, as some of Firefox 1.0 will still be under the NPL. (But
translators are not required to translate it.)

Gerv

Comment 7

[Steffen Wilberg]

Attachment: copy the NPL to toolkit/content/

The MPL is already there.

Comment 8

[Steffen Wilberg]

Comment on attachment 156846 [details] [diff] [review]
copy the NPL to toolkit/content/

Trivial change.

Comment 9

[Steffen Wilberg]

I don't think we need the "+" in toolkit/content/jar.mn, because we don't need
to override something here.

I don't know why every second line in the NPL/MPL is a blank line, but that's
the style of these files.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 156846 [details] [diff] [review]
copy the NPL to toolkit/content/

r+a=[e-mail]

Comment 11

[Steffen Wilberg]

Checked into branch...
Checking in mozilla/toolkit/content/NPL-1.1.html;
/cvsroot/mozilla/toolkit/content/Attic/NPL-1.1.html,v  <--  NPL-1.1.html
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in mozilla/toolkit/content/jar.mn;
/cvsroot/mozilla/toolkit/content/jar.mn,v  <--  jar.mn
new revision: 1.6.8.2; previous revision: 1.6.8.1
done

...and trunk:
Checking in mozilla/toolkit/content/NPL-1.1.html;
/cvsroot/mozilla/toolkit/content/NPL-1.1.html,v  <--  NPL-1.1.html
new revision: 1.2; previous revision: 1.1
done
Checking in mozilla/toolkit/content/jar.mn;
/cvsroot/mozilla/toolkit/content/jar.mn,v  <--  jar.mn
new revision: 1.7; previous revision: 1.6
done

Comment 12

[Gervase Markham [:gerv]]

This was checked into both branch and trunk; resolving FIXED.

Gerv