255649 - GtkMozEmbed crashes if its ref_count reaches 0 [@ EmbedPrivate::Destroy ]

Status: RESOLVED DUPLICATE of bug 249520

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Torsten Schoenfeld]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040621 Galeon/1.3.16
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040621 Galeon/1.3.16

If its ref_count drops to 0 and the GtkMozEmbed widget is being finalized,
something goes wrong and a segfault occurs.  A sample program exhibiting the
problem and a backtrace are attached.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Torsten Schoenfeld]

Attachment: Sample program

Comment 2

[Torsten Schoenfeld]

Attachment: Backtrace

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Dup of bug 249520 ?

Comment 4

[Torsten Schoenfeld]

Yes, looks like it is.  Showing the widget before destroying it does indeed
prevent it from segfaulting.

Comment 5

[Olivier Cahagne]

can you either test the patch or 1.7.2 and report back if working fine ?

Comment 6

[Torsten Schoenfeld]

The bug is still present in 1.7.2 (and the patch doesn't seem to be in it
either), but applying the patch from bug 249520 to 1.7.2 did indeed fix the problem.

Comment 7

[Olivier Cahagne]

Thanks for the update, the patch was checked in after 1.7.2, it's fixed in
1.7.3, the 1.7 branch shows it:
http://lxr.mozilla.org/mozilla1.7/source/embedding/browser/gtk/src/gtkmozembed2.cpp#524

*** This bug has been marked as a duplicate of 249520 ***