255656 - Gtk-WARNING/Gdk-CRITICAL/GLib-GObject-WARNING every time menus are accessed

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Jeremy M. Dolan]

I've been seeing this for a month or so, and figured someone was on top of it,
but it's been getting annoying, and a query tonight turned up nothing.

Anytime I access a menu (either from the menu toolbar, or a context menu), I get
a ton of Gtk/Gdk assertions printed to STDERR. RHL 8.0, gtk2-2.0.6-8,
gdk-pixbuf-0.18.0-4. This wasn't happening, if I recall correctly, on 0.9.1.

The errors are in this sequence:

(Gecko:6807): Gtk-WARNING **: gtkwidget.c:6188: widget class `GtkMenuItem' has
no property named `selected_shadow_type'

(Gecko:6807): Gdk-CRITICAL **: file gdkgc-x11.c: line 645
(gdk_gc_set_clip_rectangle): assertion `GDK_IS_GC (gc)' failed

(Gecko:6807): Gdk-CRITICAL **: file gdkgc-x11.c: line 645
(gdk_gc_set_clip_rectangle): assertion `GDK_IS_GC (gc)' failed

(Gecko:6807): Gdk-CRITICAL **: file gdkgc-x11.c: line 645
(gdk_gc_set_clip_rectangle): assertion `GDK_IS_GC (gc)' failed

(Gecko:6807): Gdk-CRITICAL **: file gdkgc-x11.c: line 645
(gdk_gc_set_clip_rectangle): assertion `GDK_IS_GC (gc)' failed

I usually get about 4 runs of those 5 errors for every menu I access. Figured I
should speak up before the PR.

Comment 1

[Jeremy M. Dolan]

Same errors continue, and also now seeing:

(Gecko:21778): GLib-GObject-WARNING **: gsignal.c:1633: signal `select_all' is
invalid for instance `0x9383b28'

being printed to my terminal hundreds of times with 0.10. This is a regression,
and quite a nuisance, not to mention how terrible it must look to new users.
Isn't there a way to tell glib and gtk not to print such extraneous warnings?
Library versions are the same as previously reported.

Comment 2

[Brian Ryner (not reading)]

Attachment: patch

This should fix the errors.  Couple of problems:

selected_shadow_type was introduced in gtk 2.1.0.  On older versions, it should
always use GTK_SHADOW_OUT.  I believe this also causes the GC error due to the
shadow type being an uninitialized value.

select_all as a signal on GtkTextView was introduced in gtk 2.2.2.  Older
versions will implement it using other signals, so we should just not attach
that signal handler.

Comment 3

[Brian Ryner (not reading)]

checked into trunk

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 161808 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 5

[Brian Ryner (not reading)]

checked into branches.

Comment 6

[Jeremy M. Dolan]

V'ing FIXED. No more "2>/dev/null" every time I run Firefox. Thanks for the
patch, Bryan. (There is a similar, less severe problem in the installer on Red
Hat 8.0, where pango warnings are printed. That one is bug 257831).