255726 - about:config context menus do not have default options bolded

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Richard Corbin]

When right clicking an option in about:config screen, the default option (i.e.
what would happen if user double-clicks) on that menu is not marked in bold.

In all other cases in Windows and Firefox that I could find the default option
is in bold.

Reproduceable: Always

Steps to Reproduce:
1. Enter about:config into location bar
2. right click any option (either boolean, integer, or string)

Actual results:
No context menu items are bold

Expected Results:
The default action (what would happen when double-clicked) should be highlighted
as a bold option in the menu.

...

So the bolded options dependant on type should be as follows:
* Boolean: Toggle
* String: Modify
* Integer: Modify

Comment 1

[:Gavin Sharp [email: [e-mail]]]

In which other cases in Firefox do you see this?

Comment 2

[Nickolay_Ponomarev]

Attachment: add default="true" and move the default items to the top of menu

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 208578 [details] [diff] [review]
add default="true" and move the default items to the top of menu

Hmm, I'm kinda thinking this menu could use a separator or two, but that can probably be dealt with that separately. r=me on the addition of the default attribute, though I think you should get mconnor or beltzner to ui-review the position changing.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 208578 [details] [diff] [review]
add default="true" and move the default items to the top of menu

ui-r+, though gavin's right, a separator between the default action and the other values is needed.

Comment 5

[Nickolay_Ponomarev]

Attachment: updated patch

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/177e0a27bd42