Closed Bug 255774 Opened 21 years ago Closed 21 years ago

number of available software updates not displayed when mail button not on toolbar

Categories

(Toolkit :: Application Update, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Details

(Keywords: fixed-aviary1.0, Whiteboard: [have patch] ready to land)

Attachments

(1 file)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040816 Firefox/0.9.1+ (Steffen) On starting a new window, the js console displays this error: Error: document.getElementById("mail-button") has no properties Source File: chrome://browser/content/browser.js Line: 1235 That's because we're accessing the mail button without it being there. The error breaks delayedStartup(), so that updatePanel.init() a few lines down isn't executed.
Attached patch patchSplinter Review
Comment on attachment 156269 [details] [diff] [review] patch Brian, this is your code :)
Attachment #156269 - Flags: review?(bryner)
Flags: blocking-aviary1.0PR?
Flags: blocking-aviary1.0?
Whiteboard: [have patch]
bryner, can you have a look. looks like a quick one.
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Flags: blocking-aviary1.0?
Whiteboard: [have patch] → [have patch] need review bryner
Attachment #156269 - Flags: review?(bryner) → review+
need some help landing from bryner
Whiteboard: [have patch] need review bryner → [have patch] ready to land
checked in on trunk and aviary branch
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: