255855 - [trunk] The dialog that opens when clicking a link to an .exe file has no radio button selected by default. This leads to a useless download!

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Norbert]

User-Agent:       Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8a3) Gecko/20040816 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8a3) Gecko/20040816 Firefox/0.9.1+

- (left) click a link that downloads an exe-file:
A window as you can see in the first attachement appears. There no radio-button
is selected!

- confirm with OK (while now radiobox is selected):

When the download has finished the error message you can see in the second
attachement appears!
The user has downloaded the file but cannot use it. I think this makes this bug
"major".




(Please note that I have found this bug with a latest-trunk nightly under
Windows 95. I have not
tested other builds.
I found this problem under Windows 95 but I guess that also other operating
systems are affected.)

Reproducible: Always
Steps to Reproduce:

Actual Results:  
No radio-button is selected. This leads to the error message.

Expected Results:  
I think that the "Save to Disk" radio-button should be selected by default to
avoid this problem.

Comment 1

[Norbert]

Attachment: window that opens after clicking an exe-link

Comment 2

[Norbert]

Attachment: error message that appears after downloading if no radio-button has been selected

Comment 3

[Ali Ebrahim]

WFM: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040913 Firefox/0.10

Please reopen if you can confirm with Firefox 1.0 PR or newer. If it doesn't
work, then try a clean profile too. If you are seeing this bug only on Windows
95, then please don't reopen. Windows 95 not supported by Firefox.

Comment 4

[Bill Mason]

This doesn't exist on the branch, but it has been on the trunk (as was
originally reported).

I see this all the time and reconfirmed it today with the 20040918 build (fresh
install/new profile).

Comment 5

[Ali Ebrahim]

Ah, my bad. For whatever reason I didn't realise this was a trunk-only problem.
I guess I didn't pay enough attention to the UA. Merging 1.0 branch to the trunk
is going to be a nightmare.

Comment 6

[Mike Pesce (:By-Tor)]

This bug is still present in the 12/05/2004 trunk builds.

Comment 7

[PikeUK]

Error: setting a property that has only a getter
Source File: file:///C:/PROGRAM%20FILES/FIREFOX/components/nsHelperAppDlg.js
Line: 484

This was broken by the patch in Bug 244624 which made <menulist>.label read-only.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in&mark=560#557

Comment 8

[Jesse Ruderman]

Aaron, the previous comment says your patch from bug 244624 caused this regression.

Comment 9

[Aaron Leventhal]

Neil, you had asked me to make the label property readonly:
https://bugzilla.mozilla.org/show_bug.cgi?id=244624#c11

Do you still want it to be readonly or should I switch it back to having a setter?

Comment 10

[Aaron Leventhal]

Actually hmm. That was my call to make the menulist label readonly, because the
label represents the selected item's label. Making it writable means that you're
choosing changing the selected option, but what happens when that option doesn't
currently exist? I guess the menulist should just show that label, but no option
is really selected.

It seems like Ben what wants to do here is to show nothing selected when the
menulist is disabled/grayed out. Seems reasonable.

Comment 11

[Aaron Leventhal]

Attachment: Restore setter for menulist label, make it similar to setting value (it will choose relevant item with same label if there is one)

Comment 12

[[e-mail]]

So why is the code trying to set the label of the menulist anyway?

Comment 13

[Aaron Leventhal]

(In reply to comment #12)
> So why is the code trying to set the label of the menulist anyway?

It's less confusing to novice users if the disabled menu list is blank.
Actually, in that case I don't see why there needs to be a menulist or radio
button at all. Why can't we just have a simpler dialog when there is really only
1 choice anyway?

Comment 14

[[e-mail]]

(In reply to comment #13)
>It's less confusing to novice users if the disabled menu list is blank.
Then set it blank using openHandler.selectedItem = null;

Comment 15

[Stephen Walker]

*** Bug 247478 has been marked as a duplicate of this bug. ***

Comment 16

[Aaron Leventhal]

Attachment: Follow Neil's simple suggestion

Comment 17

[Steffen Wilberg]

menulist.setAttribute("label", newlabel); still works btw.

Comment 18

[Mike Connor [:mconnor]]

Comment on attachment 169357 [details] [diff] [review]
Follow Neil's simple suggestion

yeah, this works.

Comment 19

[Aaron Leventhal]

Checking in nsHelperAppDlg.js.in;
/cvsroot/mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in,v  <-- 
nsHelperAppDlg.js.in
new revision: 1.18; previous revision: 1.17
done

Comment 20

[Bill Mason]

V 20041224 PC/Win2000