When handling a fault in nsIWebServiceCallContext it crashes

RESOLVED FIXED

Status

Core Graveyard
Web Services
--
critical
RESOLVED FIXED
14 years ago
6 months ago

People

(Reporter: Cédric Chantepie, Assigned: Cédric Chantepie)

Tracking

({crash})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

14 years ago
When an SOAPFault is handled as nsIException in wspcallcontext.cpp it crashes
when mListener->OnError is called throught xptc
(Assignee)

Comment 1

14 years ago
Created attachment 156372 [details] [diff] [review]
Patch for trunk

Thanks a lot to scc and timeless for this patch
(Assignee)

Comment 2

14 years ago
Created attachment 156374 [details] [diff] [review]
Patch for aviary

Thanx to scc and timeless for their help about that crash

Updated

14 years ago
Attachment #156372 - Flags: superreview?(shaver)
Attachment #156372 - Flags: review+
Comment on attachment 156372 [details] [diff] [review]
Patch for trunk

+    nsCOMPtr<nsISupports> canonical_this = 
+      do_QueryInterface(NS_STATIC_CAST(nsIWebServiceCallContext*, this));

Why do you need the STATIC_CAST here? Can't you just do_QueryInterface(this)?
Move it down to where you set [1].val.p, too.

+    dispatchParams[0].val.p = mException;

Maybe it's not necessary, but I'd prefer mException.get().
Comment on attachment 156372 [details] [diff] [review]
Patch for trunk

timeless explained why the STATIC_CAST is necessary. Fix the rest.
Attachment #156372 - Flags: superreview?(shaver) → superreview+
Don't forget that if you want this on Aviary you'll also need to get it into 1.7.

Updated

14 years ago
Keywords: crash
(Assignee)

Comment 6

14 years ago
(In reply to comment #5)
> Don't forget that if you want this on Aviary you'll also need to get it into 1.7.

Do I need to do something special for 1.7 ? aviary patch should apply on that ...
(Assignee)

Comment 7

14 years ago
Created attachment 156487 [details] [diff] [review]
Fixed patch for trunk

Change '= mException' to '= mException.get()'
(Assignee)

Comment 8

14 years ago
Created attachment 156488 [details] [diff] [review]
Fixed patch for aviary

Comment 9

14 years ago
Comment on attachment 156372 [details] [diff] [review]
Patch for trunk

mozilla/extensions/webservices/proxy/src/wspcallcontext.cpp	1.13
Attachment #156372 - Attachment is obsolete: true

Updated

14 years ago
Attachment #156374 - Attachment is obsolete: true

Updated

14 years ago
Attachment #156488 - Flags: approval1.7.3?

Comment 10

14 years ago
Comment on attachment 156488 [details] [diff] [review]
Fixed patch for aviary

a=mkaply for 1.7
Attachment #156488 - Flags: approval1.7.3? → approval1.7.3-
(Assignee)

Comment 11

14 years ago
(In reply to comment #10)
> (From update of attachment 156488 [details] [diff] [review])
> a=mkaply for 1.7
> 

Patch doesn't work ? what should be done ? ...

Comment 12

14 years ago
Comment on attachment 156488 [details] [diff] [review]
Fixed patch for aviary

weird.
Attachment #156488 - Flags: approval1.7.3- → approval1.7.3+

Updated

14 years ago
Assignee: web-services → chantepie
(Assignee)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

6 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.