255927 - When handling a fault in nsIWebServiceCallContext it crashes

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Cédric Chantepie]

When an SOAPFault is handled as nsIException in wspcallcontext.cpp it crashes
when mListener->OnError is called throught xptc

Comment 1

[Cédric Chantepie]

Attachment: Patch for trunk

Thanks a lot to scc and timeless for this patch

Comment 2

[Cédric Chantepie]

Attachment: Patch for aviary

Thanx to scc and timeless for their help about that crash

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 156372 [details] [diff] [review]
Patch for trunk

+    nsCOMPtr<nsISupports> canonical_this = 
+      do_QueryInterface(NS_STATIC_CAST(nsIWebServiceCallContext*, this));

Why do you need the STATIC_CAST here? Can't you just do_QueryInterface(this)?
Move it down to where you set [1].val.p, too.

+    dispatchParams[0].val.p = mException;

Maybe it's not necessary, but I'd prefer mException.get().

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 156372 [details] [diff] [review]
Patch for trunk

timeless explained why the STATIC_CAST is necessary. Fix the rest.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Don't forget that if you want this on Aviary you'll also need to get it into 1.7.

Comment 6

[Cédric Chantepie]

(In reply to comment #5)
> Don't forget that if you want this on Aviary you'll also need to get it into 1.7.

Do I need to do something special for 1.7 ? aviary patch should apply on that ...

Comment 7

[Cédric Chantepie]

Attachment: Fixed patch for trunk

Change '= mException' to '= mException.get()'

Comment 8

[Cédric Chantepie]

Attachment: Fixed patch for aviary

Comment 9

[timeless]

Comment on attachment 156372 [details] [diff] [review]
Patch for trunk

mozilla/extensions/webservices/proxy/src/wspcallcontext.cpp	1.13

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 156488 [details] [diff] [review]
Fixed patch for aviary

a=mkaply for 1.7

Comment 11

[Cédric Chantepie]

(In reply to comment #10)
> (From update of attachment 156488 [details] [diff] [review])
> a=mkaply for 1.7
> 

Patch doesn't work ? what should be done ? ...

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 156488 [details] [diff] [review]
Fixed patch for aviary

weird.