Closed
Bug 256006
Opened 21 years ago
Closed 21 years ago
XUL Frames compute MEW when it is not necessary
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Unassigned)
Details
Attachments
(1 file)
|
1.76 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
The BoxLayoutState takes the address of aDesiredSize.mMaxElementWidth as it
worked previously with the MES. After this the non nullness is used as a
criteria whether the MEW should be computed or not
(http://lxr.mozilla.org/seamonkey/search?string=state.GetMaxElementWidth%28%29
). This is pretty old style and now that we have the mComputeMEW flag
mMaxElementWidth is a member variable and its address is always non null.
Comment on attachment 156440 [details] [diff] [review]
patch
David, did you leave that code intentional when you switched from size to
width?
Attachment #156440 -
Flags: superreview?(dbaron)
Attachment #156440 -
Flags: review?(dbaron)
Attachment #156440 -
Flags: superreview?(dbaron)
Attachment #156440 -
Flags: superreview+
Attachment #156440 -
Flags: review?(dbaron)
Attachment #156440 -
Flags: review+
this thing has been checked in on august 27th
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
Assignee | |
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•