256025 - Creating new bookmark in Quick Searches folder yields separator in menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Blake Ross]

Today's branch nightly, clean profile, clean everything.

Steps to Reproduce:

1. Open the Bookmarks menu and select the Quick Searches submenu.
2. Right click on a quick search menu and choose New Bookmark...
3. Enter http://www.xanga.com/home.aspx?user=%s for the url and xanga for the
keyword.
4. Return to the Quick Searches submenu.

Result: a separator appears.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Blake, this seems to be fixed; I can't reproduce in an 0829 build.  Can you
retest and close this if it is fixed?

Comment 2

[Walter K.]

This happens once in a while to me too (currently FF PR1). Usually, I need to
have more than one browser window open for this behavior to show up. And only
the window in which the new bookmark was created shows a separator instead of
the new bookmark. Any other open window would show the bookmark.

Comment 3

[Phil Ringnalda (:philor)]

Reproduced first try, with only one window open, same steps but different
URL/keyword, with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20041006 Firefox/0.10.1

The menu shows a separator, both the sidebar and bookmarks manager show the
bookmark. Moving the new bookmark a couple spots up in the sidebar makes it
appear in the menu, but a double-separator (the real one and the
bookmark-as-separator) still appear in the menu.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: 256025-creating-bookmark-yields-separator-0.patch

This was a fun one.  The problem was that when a new item is created, because
the template builder sucks, it goes to the end of the menu -- past the open in
tabs separator and menu item.  The code that was hiding open in tabs was rather
simplistic before, so what it ended up doing was remove the last two items in
the menu, thus removing the new item and the "open in tabs" menu item, but
leaving the separator.	When you opened the submenu again, you'd get a new
separator and a new open in tabs menu item, leaving you with a separator where
you'd expect the new item to be.

This patch lets us walk up the menu children and only remove the items that we
explicitly know are open in tabs goop.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

*** Bug 263965 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 161807 [details] [diff] [review]
256025-creating-bookmark-yields-separator-0.patch

Comparisons against |class| should probably check that it contains the target
as a whitespace-delimited word, rather than testing identity, to support
class="foo bar" correctly.  This'll do for now, though, since we don't seem to
use multiple classes anywhere in this part of the UI.

Comment 7

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change