256045 - Download Manager options (open, remove, cancel, et. al.) give no visual feedback when clicked or hovered over with the mouse.

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Daniel Beckham]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

The Download Manager in the Mac OS X build of Firefox 0.9.3 gives no visual
feedback when clicking or hovering over any of the options for a particular
download.  It's not immediately obvious what option you have selected or are
trying to select and it's disorienting and not kind to the user.

Reproducible: Always
Steps to Reproduce:
1. Open Firefox and download a random file from the web.
2. Open your Download Manager and move your mouse over any option available for
that download. (open, remove, retry, cancel, pause, etc.)
3. Click one of those options.

Actual Results:  
You receive no visual feedback at all.

Expected Results:  
Behaved similarly as to how the Windows build of Firefox behaves.  When your
mouse hovers over a option, the mouse pointer should change to the appropriate
"selection" pointer for the Mac OS X system.  Usually this is a hand with the
pointer finger pointing upwards.  

Once the mouse is pressed, the option should give some sort of visual feedback
indicating that it was pressed.  The Windows version simply moves the selection
reticle to the option and turns the option text red.

Whatever the methods used to give feedback, the short and simple is that the
downloads manager is rendered the same way a web page would be rendered (using
underlined links that perform some action) and should give visual feedback
appropriately.

Comment 1

[Bruce Davidson]

Confirming this bug on 0.9.3 on MacOS X 10.3.5. Can't find any duplicates.

I suspect this is a case of the Mac stylesheets not having all the styles that
Windows theme has at the moment. Once my trunk build is cvs updated I'll look
into this, might be simple enough to fix.

Comment 2

[Bruce Davidson]

As suspected the bug is a couple of missing rules in the downloads.css
stylesheet. I'm just fine tuning a fix (the focus reticle looks really
un-Mac-like, so I don't think I'll implement that bit). Taking this bug and
nominating for blocking 1.0mac.

Comment 3

[Bruce Davidson]

Attachment: Proposed patch

The attached patch provides the following feedback in the viewer:
 - Mouse pointer changes to pointer when over any of the "cancel", "open" etc
links.
 - Links flash red when clicked with mouse button.
I don't use the dotted background that the winstripe theme uses for keyboard
focus, because (to my mind) it doesn't look very Mac-like. I welcome any
thoughts on ways of showing focus.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 156673 [details] [diff] [review]
Proposed patch

let Kevin review this, I have no idea on what's "right" for pinstripe.

Comment 5

[Daniel Beckham]

For what it's worth, Thunderbird uses the focus reticle and red color for links
in emails.  Safari simply turns the link red.  Either would probably be
perfectly fine.

Comment 6

[Kevin Gerich]

Comment on attachment 156673 [details] [diff] [review]
Proposed patch

the patch is fine. go ahead with and check it in. I'm going to revisit the
download window soon. Hopefully there will be a way to replace the links with
icons.

Comment 7

[Asaf Romano (gone)]

Checking in pinstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.4; previous revision: 1.3
done