256069 - Mozilla does not build on NetBSD 1.5.x; CODESET not defined

Status: RESOLVED DUPLICATE of bug 160180

(Core :: Internationalization, defect)

Description

[Havard Eidnes]

User-Agent:       Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.6) Gecko/20040609 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.6) Gecko/20040608

Mozilla does not build on NetBSD 1.5.x.  On those versions, the
locale implementation is rather minimal, so the CODESET macro is
not defined.  This causes a build system, as the source file
xpcom/io/nsNativeCharsetUtils.cpp unconditionally makes use of
that macro.  Making it preprocessor conditional makes the browser
build.

Reproducible: Always
Steps to Reproduce:
1. Try to compile mozilla on NetBSD 1.5.x without the pkgsrc patch patch-bn.
2. Watch it fail.




Expected Results:  
A browser which builds on NetBSD 1.5.x.

It's a goal to reduce the number of local non-OS-specific patches
which will need to be maintained and updated on update of the NetBSD
pkgsrc mozilla package.

The FireFox program has the same problem, BTW, originally found when
it was called phoenix.

Comment 1

[Havard Eidnes]

Attachment: Patch making use of CODESET conditional

Comment 2

[Jungshik Shin]

That should be checked by configure. configure(.in) does check it and set
HAVE_LANGINFO_CODESET accordingly. I wonder why it fails on NetBSD.

Comment 3

[Havard Eidnes]

It appears that this is a remnant from the days of phoenix 0.4
and mozilla of the same vintage (1.2.1).  I can confirm that
mozilla 1.7.2 builds fine without this patch on netbsd-1-5, so
I'll just go ahead and close this bug and remove the corresponding
patch from NetBSD's pkgsrc.

Thanks!

Comment 4

[Jason Bassford]

No bug / patch specified as the actual fix.

->WORKSFORME

Comment 5

[cls]

Actually, this is a dupe of a fixed bug.

Comment 6

[cls]

*** This bug has been marked as a duplicate of 160180 ***