25615 - [MLK] nsStdURL leaking C strings

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Patrick C. Beard]

At the CVS blame URL above, you will see a call to DupString(&mRef, ...) where 
mRef can already have a pointer to a C string in it, thus duping over it leaks 
memory. There are a few other call sites to DupString() in this file that look 
suspicious to me. The proof is that the following patch removes the memory leaks 
that I'm observing with the Boehm leak detector:

Index: mozilla/netwerk/base/src/nsStdURL.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/base/src/nsStdURL.cpp,v
retrieving revision 1.39
diff -c -2 -r1.39 nsStdURL.cpp
*** nsStdURL.cpp	2000/01/28 07:40:31	1.39
--- nsStdURL.cpp	2000/01/29 03:04:29
***************
*** 824,827 ****
--- 824,828 ----
          ? and ; as well. 
      */
+     CRTFREEIF(mRef);
      nsresult status = DupString(&mRef, 
             (i_Ref && (*i_Ref == '#')) ?  (i_Ref+1) : i_Ref);
***************
*** 832,835 ****
--- 833,837 ----
  nsStdURL::SetParam(const char* i_Param)
  {
+     CRTFREEIF(mParam);
      nsresult status = DupString(&mParam, 
              (i_Param && (*i_Param == ';')) ? (i_Param+1) : i_Param);
***************
*** 840,843 ****
--- 842,846 ----
  nsStdURL::SetQuery(const char* i_Query)
  {
+     CRTFREEIF(mQuery);
      nsresult status = DupString(&mQuery, 
              (i_Query && (*i_Query == '?')) ? (i_Query+1) : i_Query);

Comment 1

[(not reading, please use [e-mail] instead)]

re-assign this to warren.

the reason my name was on the code was because I backed out warren.

cc'ing andreas as well.

Comment 2

[Andreas Otte]

Already included in ANDREAS_URL2_BRANCH

Comment 3

[Warren Harris]

Andreas, Is this fixed now?

Comment 4

[Andreas Otte]

Yes, this CStrings no longer leak.

Comment 5

[Tom Everingham]

marking verified per engineer's comments