256165 - xmlns attribute on XUL elements doesn't have xmlns namespace

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[steve.swanson]

Attributes of the form xmlns= and xmlns:prefix= should have http://www.w3.org/ 
2000/xmlns/ as their namespaceURI.  In XUL, the prefix type do, but the non-
prefixed ones don't.  See the testcase.

This might be related to bug 75870.

This issue came up in my patch for bug 133827 where I had to hack around the 
missing namespaceID on the xmlns attribute on XUL elements.

Most likely, this is a problem in XULContentSinkImpl::NormalizeAttributeString
(), 
http://lxr.mozilla.org/seamonkey/source/content/xul/document/src/nsXULContentSi
nk.cpp#693

Comment 1

[steve.swanson]

Attachment: testcase

click the button, see the attributes and corresponding namespaceURI

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Sync up XUL content sink to what XML does

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 158841 [details] [diff] [review]
Sync up XUL content sink to what XML does

This makes XUL do the same thing that XML does (in AddAttributes in the XML
sink) for the "xmlns" attribute.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 158841 [details] [diff] [review]
Sync up XUL content sink to what XML does

sr=jst

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 158841 [details] [diff] [review]
Sync up XUL content sink to what XML does

>Index: content/xul/document/src/nsXULContentSink.cpp
>===================================================================

>+    } else {
>+        if (nameAtom == nsLayoutAtoms::xmlnsNameSpace) {
>+            nameSpaceID = kNameSpaceID_XMLNS;
>+        }
>+        // else use kNameSpaceID_None
>     }

I'd just make that an else if (...) { and move the comment one line down.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8a4.