256266 - Filepicker invoked from Attach Web Page in Compose should default to 'HTML Files' instead of 'All Files'.

Status: RESOLVED DUPLICATE of bug 662203

(SeaMonkey :: Download & File Handling, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: 2004-08-19-08, Windows XP Seamonkey Trunk.

See bug 248193 for some history.

1.  In Mail, click Compose.
2.  Now, select 'Attach | Web Page' from either the File menu or the toolbar.
3.  Click on 'Choose File'.
4.  Examine the resulting filepicker, notably:

'Files of Type' *under Windows XP, at least*, which shows, by default:

Actual Results:

'All Files'

Expected Results:

'HTML Files'

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

I don't have a tree, but would this work?

picker.appendFilters(FILTER_HTML);

Comment 2

[Ian Neal]

Attachment: Patch v0.1

This patch:
* Adds HTML filter before adding other filters so it is listed in the required
order.

Comment 3

[[e-mail]]

This also affects the Open Location dialog's filepicker.
On Linux, All Files is added last, but on other platforms it's first.

Comment 4

[Ian Neal]

Attachment: Revised patch v0.1a

Changes since v0.1
* Moved to using buttonlabelaccept in MsgAttachPage
* Match urlbar behaviour between MsgAttachPage and openLocation - both now use
focus()
* Make HTML appear first for openLocation
* Remove second Text filter for New Composer Window option

Comment 5

[Ian Neal]

Attachment: Tweaked patch v0.1b

Changes since v0.1a:
* Simplified filter selections for window types.

Comment 6

[[e-mail]]

I still think we should strive for a) consistency and b) usefulness across
filepicker implementations and that means fixing this bug at that level.

Comment 7

[Wayne Mery (:wsmwk)]

Ian leaving this assigned to you

Comment 8

[Wayne Mery (:wsmwk)]

strikes me as being Seamonkey bug, no?

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 180164 [details] [diff] [review]
Tweaked patch v0.1b

The files in mailnews/compose/resources/content/ no longer exist, so this patch no longer applies.

Ian, up for a new patch? :)

Comment 10

[Philip Chee]

Fixed in Bug 662203.