Closed
Bug 256383
Opened 20 years ago
Closed 20 years ago
Unknown 'lang' should be mapped to 'x-unicode' instead of 'x-western'
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: jshin1987, Assigned: jshin1987)
References
Details
(Keywords: fixed-aviary1.0, fixed1.7.5, intl)
Attachments
(2 files)
1.19 KB,
patch
|
smontagu
:
review+
rbs
:
superreview+
|
Details | Diff | Splinter Review |
1.24 KB,
patch
|
mkaply
:
approval-aviary+
mkaply
:
approval1.7.5+
|
Details | Diff | Splinter Review |
Currently, an unknown 'lang' (by 'unknown', I mean those 'lang' for which the corresponding internal 'langGroup' is not listed in langGroup.properties file) is mapped to 'x-western'. This mapping is used exclusively by Gfx (and layout) [1] to determine 'lang-specific' fonts. On some platforms, Mozilla can support quite a lot more languages (actually scripts) than what we have in langGroup.properties. To control fonts to use for those languages, currently one has to change fonts for Western because by any stretch, those scripts are similar to Latin (e.g. various Indic scripts). Until we add them to our 'supported' list, it'd be better to map them to 'x-unicode' so that fonts to use for them can be controlled by setting fonts for 'Unicode' in the font preference panel. This is quite 'intuitive' because most of those scripts can ONLY be representable in Unicode (if you don't count unstandardized/unsupported hacks used for those scirpts in the past) and web pages in those scripts are mostly in UTF-8 (or other encoding forms of Unicode). [1] http://lxr.mozilla.org/seamonkey/ident?i=LookupLanguage http://lxr.mozilla.org/seamonkey/ident?i=GetLocaleLanguageGroup
Assignee | ||
Comment 1•20 years ago
|
||
btw, this bug was spun off from bug 256257
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 156657 [details] [diff] [review] patch as proposed in comment #0 asking for r/sr
Attachment #156657 -
Flags: superreview?(rbs)
Attachment #156657 -
Flags: review?(smontagu)
Assignee | ||
Comment 3•20 years ago
|
||
*** Bug 204586 has been marked as a duplicate of this bug. ***
Comment on attachment 156657 [details] [diff] [review] patch as proposed in comment #0 sr=rbs
Attachment #156657 -
Flags: superreview?(rbs) → superreview+
Updated•20 years ago
|
Attachment #156657 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 5•20 years ago
|
||
thansk for r/sr. fix checked into the trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•20 years ago
|
||
Assignee | ||
Comment 7•20 years ago
|
||
Comment on attachment 158376 [details] [diff] [review] patch for aviary 1.0 and 1.7 branch There's little risk with this change, which only affects cases where languages not yet listed in our lang-to-langGroup mapping table.
Attachment #158376 -
Flags: approval1.7.x?
Attachment #158376 -
Flags: approval-aviary?
Comment 8•20 years ago
|
||
Comment on attachment 158376 [details] [diff] [review] patch for aviary 1.0 and 1.7 branch a=mkaply for branches jshin, do you think this will fix this OS/2 bug? http://bugzilla.mozilla.org/show_bug.cgi?id=248792
Attachment #158376 -
Flags: approval1.7.x?
Attachment #158376 -
Flags: approval1.7.x+
Attachment #158376 -
Flags: approval-aviary?
Attachment #158376 -
Flags: approval-aviary+
Comment 9•20 years ago
|
||
Does this patch cause x-unicode to sent as a language atom to nsFontMetrics?
Comment 10•20 years ago
|
||
This bug seems to have an aviary branch checkin associated with it. If this has landed on the aviary branch (as much as it's going to for 1.0) can you please add the "fixed-aviary1.0" keyword? Thanks.
Assignee | ||
Updated•20 years ago
|
Keywords: fixed-aviary1.0,
fixed1.7.x
You need to log in
before you can comment on or make changes to this bug.
Description
•