256407 - Add a "Customize toolbar" option to the view menu

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Simon Paquet [:sipaq]]

We need to make "Customize toolbar" more accessible.

Comment 1

[Simon Paquet [:sipaq]]

Attachment: patch v1

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 156677 [details] [diff] [review]
patch v1

>+<!ENTITY calendar.menu.customize.label                "Customize Toolbar">
>+<!ENTITY calendar.menu.customize.accesskey            "C">

I like "Customize Toolbars" better. plural form, there are usually multiple
bars. (menu + main)


>Index: sunbird/base/content/menuOverlay.xul
> 	 </menupopup>
>-	 </menu>	 
>+	 </menu>
>+         <menuseparator/>
>+         <menuitem id="calendar-view-menu-customize"
>+                   command="cmd_CustomizeToolbars"
>+                   label="&calendar.menu.customize.label;"
>+                   accesskey="&calendar.menu.customize.accesskey;"/>

Identation is weird here. A closing <menu>, and the next line is indented more?
Ah, tabs...
Can you try to fix that?

Comment 3

[Simon Paquet [:sipaq]]

Attachment: patch v2

Hi mvl, 
this patch should address your review comments. I changed the wording to
"Customize toolbars" and coverted all tabs to spaces in menuOverlay.xul.

Comment 4

[Simon Paquet [:sipaq]]

Comment on attachment 157316 [details] [diff] [review]
patch v2

bringing review+ over from first patch.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Checked in

Comment 6

[Justin Wood (:Callek)]

Does this need to exist in Suite as well...I just noticed the bug in my backlog
of watched bug-spam ;-)  We do not allow "Customize Toolbar" in suite, (or FF
iirc) but we do allow it in Sunbird, so this should only be there, just add a
new entry to sunbirds jar.mn file, and add this to the Sunbird DIR instead of
suite, imo.

Mvl ;; reopen?

Comment 7

[Mostafa Hosseini]

The patch touches calendar/resources/content/menuOverlay.xul while it should touch 
calendar/sunbird/base/content/menuOverlay.xul

Please fix.

Comment 8

[Simon Paquet [:sipaq]]

Attachment: Correct my mistake

Sorry for the mess. I got this right in my first patch, but was a little bit
sloppy when preparing the second. This should fix the issue.

Comment 9

[Mostafa Hosseini]

Attachment 157434 [details] [diff] checked in.

Comment 10

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!