256630 - [firefox only] style attribute doesn't show up in style rules view

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The style attribute doesn't show up in the style rules view in inspector because
XPCNativeWrapper.js isn't available in Firefox.

Comment 1

[timeless]

i hope you don't consider this to be a bug in domi. it is not in domi's interest
to help webpages attack the user's computer.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What in the world are you talking about?  We need to make XPCNativeWrapper.js
available in Firefox -- not stop using it.

Comment 3

[timeless]

well the fix is to move that file from communicator to somewhere else
(toolkit?), i just don't quite understand why this bug is filed in domi, you're
going to have to fix a bunch of other components (editor, bookmarks) when you
make that move.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Because the only real problem caused by the bug is in DOM Inspector?

Comment 5

[Alex Vincent [:WeirdAl]]

I don't see how the style attribute can be used "to help webpages attack the 
user's computer".  The style attribute may be deprecated in HTML, yes, but it's 
still quite valid.

My two bits; I'm rusty on style rules panel.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 159522 [details] [diff] [review]
patch

>Index: mail/config/mail-jar.mn

>+content/global/XPCNativeWrapper.js,                   toolkit/content/global/XPCNativeWrapper.js

But the file isn't in toolkit/content/global, is it?  It's in
xpfe/global/resources/content.	Does firefox already pull in xpfe/global, then?

I assume you're doing CVS repository move of the file too?

sr=bzbarsky if you are and if the mail-jar issue is ok.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

mail-jar.mn is used to repack unpacked JAR files, not source files, so since
it's packaged at the location content/global in toolkit.jar (per
xpfe/global/jar.mn), that's the location it should be at when the JAR file is
unpacked.

And yes, I'm planning a repository-copy.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 159522 [details] [diff] [review]
patch

I'd like to land this on aviary both because the inspector thing is annoying
and because we may find at some point that we need this urgently on the branch.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-09-21 17:42 -0700.

Comment 11

[Pierre Chanial]

Unless XPCNativeWrapper.js gets added to toolkit/content, it won't be included
in the firefox (or xulrunner app) toolkit.jar because we prune xpfe/global
during mozilla/xpfe build (doesn't apply for thunderbird).
see: http://lxr.mozilla.org/seamonkey/source/xpfe/Makefile.in

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So why did the fix work for me?  Or is this a packaging issue for only some
types of builds?

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hrm.  Maybe I built in xpfe/global.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: additional patch

Well, I guess I'm required to fork yet another file by a horrible pro-forking
architecture.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 159779 [details] [diff] [review]
additional patch

(plus the obligatory cvs repository copy into toolkit/content/)

Comment 16

[Pierre Chanial]

Comment on attachment 159779 [details] [diff] [review]
additional patch

> Well, I guess I'm required to fork yet another file by a horrible pro-forking
architecture.

the suite should pull mozilla/toolkit, build it and then build mozilla/xpfe.
That way, the duplicated files could be removed in xpfe/global, and the ones
that are different could be overridden.

Needless to say that toolkit/content should then have the regular r+sr policy
and the aviary peer compulsory review should be waived for this directory...

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK, really fixed now (2004-09-23 09:56 -0700).

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 159522 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to AVIARY_1_0_20040515_BRANCH, 2004-09-24 14:49/50 -0700.