Closed Bug 256640 Opened 21 years ago Closed 21 years ago

Make document.all act as a collection (document.getElementsByTagName("*"))

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jst, Assigned: jst)

References

Details

(Keywords: fixed-aviary1.0, fixed1.7.5)

Attachments

(1 file)

IE lets developers do document.all[2] to access the second element in the document. We can do the same, and doing that would fix yet a few more compatibility problems... Patch coming up.
Attachment #156833 - Flags: superreview?(brendan)
Attachment #156833 - Flags: review?(brendan)
Comment on attachment 156833 [details] [diff] [review] Make document.all a collection too Fix the s/chaper/cheaper/typo, and tighten up the CallToGetPropMapper logic to check whether the class of its |obj| param is sHTMLDocumentAllClass, and r+sr=me. Pre-approving for aviary and 1.7.3 based on bclary's thumbs-up. /be
Attachment #156833 - Flags: superreview?(brendan)
Attachment #156833 - Flags: superreview+
Attachment #156833 - Flags: review?(brendan)
Attachment #156833 - Flags: review+
Attachment #156833 - Flags: approval1.7.3+
Attachment #156833 - Flags: approval-aviary+
s/second/third/ in comment 0 "document.all[2] to access the second element...." /be
Fixed on trunk and aviary branch.
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
This didn't go onto the aviary branch according to bonsai...
Thanks, good catch. I had a typo in my checkin command that I missed, so it hadn't gone in yet. Duh Fixed on the aviary branch now.
*** Bug 253451 has been marked as a duplicate of this bug. ***
Fixed on the 1.7 branch.
Depends on: 248549
Keywords: fixed1.7.x
This caused bug 289263
Depends on: 289263
Assignee: general → jst
QA Contact: ian → general
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: