256691 - E4X: hasSimpleContent can return false for attribute names

Status: RESOLVED FIXED

(Rhino Graveyard :: E4X, defect)

Description

[Igor Bukanov]

Consider the following test case which is based on example from Richard McKinley:

var xml = <a attrname="something"> <b> <c/> </b> </a> ;
var simple = [e-mail]();
print (simple);

Since xml.@attrname is attribute this should print true in the shell. Instead it
prints false. This is rather sensitive to the structure of <a>, even slight
alterations restore the original behavior.

The bug is also visible in the following example:

var xml = <a attrname="something"> <b> <c/> </b> </a> ;
print(xml.@attrname == "something");

which prints false since xml == string can only be true if
xml.hasSimpleContent() is true and that simple content equals to the string.

Comment 1

[Igor Bukanov]

Attachment: Fix: always assume simple content for attribute and text

For some reasons XmlCursor when it is recreated for the attribute attrname
returns true for toFirstChild call in the implementation of
XML.hasSimpleContent(). It can be a bug in xmlbeans or something that I do get.
In any case the patch forces hasSimpleContent to return true for attribute and
pure text cursor fixing the problem.

Comment 2

[Igor Bukanov]

I committed the fix