256757 - misused printf causes crash [@ nsXPCWrappedJSClass::CheckForException]

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

This line in nsXPCWrappedJSClass::CheckForException crashes when my extension 
causes an error:

printf(text);

because text contains "C:\Documents%20and%20Settings\...".

Comment 1

[Jesse Ruderman]

Attachment: patch: replace printf(...) with fputs(..., stderr)

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 156914 [details] [diff] [review]
patch: replace printf(...) with fputs(..., stderr)

r+sr=jst, but why make this go to stderr now when it used to go to stdout? I'd
say s/stderr/stdout/ in the diff unless there are good reasons not to.

Comment 3

[Jesse Ruderman]

Attachment: same patch, but with stdout

Comment 4

[Jesse Ruderman]

Checked in on trunk.

Comment 5

[Jesse Ruderman]

Since this was a safe crash/security fix, I got a=tor and checked in on 1.7.x
and aviary.