Closed Bug 256898 Opened 20 years ago Closed 20 years ago

Wrong prototype for NPN_IdentifierIsString(), and intfromidentifier, hasmethod, and hasproperty not initialized in NPNFuncs.

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jst, Assigned: jst)

Details

(Keywords: fixed-aviary1.0, fixed1.7.5)

Attachments

(1 file)

Fix.
3.04 KB, patch
brendan
: review+
brendan
: superreview+
asa
: approval-aviary+
asa
: approval1.7.5+
Details | Diff | Splinter Review 
In the recent additions to the NPAPI, I forgot to initialize some NPNFunction
callback pointers, and the NPN_IdentifierIsString() in npruntime.h was wrong.
Patch coming up.
Attached patch Fix. — — Splinter Review 

    
  

        Attachment #156995 -
        Flags: superreview?(brendan)

        Attachment #156995 -
        Flags: review?(brendan)

    
    

    
  
Comment on attachment 156995 [details] [diff] [review]
Fix.

Duh, yeah.

/be

        Attachment #156995 -
        Flags: superreview?(brendan)

        Attachment #156995 -
        Flags: superreview+

        Attachment #156995 -
        Flags: review?(brendan)

        Attachment #156995 -
        Flags: review+

    
    

    
  
Comment on attachment 156995 [details] [diff] [review]
Fix.

No reason not to take these corrections on the brances, IMO.

        Attachment #156995 -
        Flags: approval1.7.3?

        Attachment #156995 -
        Flags: approval-aviary?

    
    

    
  
Comment on attachment 156995 [details] [diff] [review]
Fix.

a=asa for branch checkins

        Attachment #156995 -
        Flags: approval1.7.3?

        Attachment #156995 -
        Flags: approval1.7.3+

        Attachment #156995 -
        Flags: approval-aviary?

        Attachment #156995 -
        Flags: approval-aviary+

    
    

    
  
Fixed on trunk and aviary branch. Not on 1.7 yet as this API doesn't exist there
yet, but might be merged there soon...
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED

    
  
Keywords: fixed1.7.5

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: