256963 - document.all warning doesn't show in Firefox JS console, dom.properties not loaded

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[PikeUK]

The document.all warning message doesn't show in the JS console in Firefox. I
assume this is because in Firefox, dom.properties is at:

chrome://global/locale/dom/dom.properties

but the backend is attempting to load it from:

chrome://communicator/locale/dom/dom.properties

http://lxr.mozilla.org/aviarybranch/source/content/base/src/nsDocumentViewer.cpp#205
http://lxr.mozilla.org/aviarybranch/source/dom/src/base/nsDOMClassInfo.cpp#348

Presumably the other warnings in dom.properties are never shown either, though I
haven't tested it.

Requesting blocking 1.0PR (don't know if this will affect localizers or not)

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.2) Gecko/20040825 Firefox/0.9.1+

Comment 1

[PikeUK]

Attachment: document.all Test

In Mozilla a warning appears in the console, in Firefox nothing happens.

Comment 2

[chris hofmann]

does the test need update for the new document.all support?

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: document.all Test with global reference

include use of global reference. Should show:

Warning: Non-standard document.all property was used. Use W3C standard
document.getElementById() instead.
Source File: file:///C:/temp/documentAll.html
Line: 9

Warning: Element referenced by ID/NAME in the global scope. Use W3C standard
document.getElementById() instead.
Source File: file:///C:/temp/documentAll.html
Line: 10

Comment 4

[Johnny Stenback (:jst)]

Attachment: Fix chrome URI to the dom.properties file

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 157572 [details] [diff] [review]
Fix chrome URI to the dom.properties file

This should be fixed for PR1

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 157572 [details] [diff] [review]
Fix chrome URI to the dom.properties file

1.7 branch merge later, eh?

/be

Comment 7

[Johnny Stenback (:jst)]

Fixed on the aviary branch. Leaving bug open to figure out if this is needed on
the trunk and/or the 1.7 branch too.

Comment 8

[Asaf Romano (gone)]

removing blocking? as this is fixed on aviary branch

Comment 9

[Benjamin Smedberg]

This is not needed on the trunk or 1.7 branch. I have not centralized the gecko
locale files on the trunk yet, pending announcements/reviews in bug 256188. I
would sure love some module owner approvals there ;)