257104 - "Empty Trash" fails to update unread mail count ot the Trash folder

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[mike.hitchcock]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8a3) Gecko/20040826
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8a3) Gecko/20040826

Old bug re-appeared in last 3 daily builds. I "Empty Trash" is selected from
File Menu to clear for example 122 messages in the trash directory, action
completes without error but Trash Directory still shows 122. I Mozilla closed
down then reloaded trash directory correctly shows empty.

Reproducible: Always
Steps to Reproduce:
1.trash directory displays positive content
2.select "Empty Trash" from File Menu
3.trash directory still displays positive content

Actual Results:  
see above

Expected Results:  
trash directory should be show a nil content

Comment 1

[Daniel Kies]

I see this too during the same time frame with trunk nightlies on winXP SP1.

Comment 2

[Daniel Kies]

Testing win32 nightlies, I find that the 20040823 win32 build works fine, and
the problem begins with the 20040824 win32 nightly.  Checkins to SeaMonkeyAll
between 20040823 and 20040824:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20040823&maxdate=20040824&cvsroot=%2Fcvsroot

Could this be aftermath of "RSS breaks after compact folder"
(http://bugzilla.mozilla.org/show_bug.cgi?id=256332), because I also see strange
message number miscounts after compacting folders in the most recent nightlies?

Comment 3

[Mike Kaply [:mkaply]]

Not Os/2 specific

Comment 4

[Stefan Borggraefe]

Confirming with Seamonkey trunk build 2004082909 on Win 2000.

This bug doesn't seem to occur with IMAP accounts.

Comment 5

[David :Bienvenu]

Darn, yes, I'm sure you're right.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

Comment 7

[David :Bienvenu]

this needs to get fixed for tbird .8 as well... which I'll take care of.

Comment 8

[Scott MacGregor]

*** Bug 256900 has been marked as a duplicate of this bug. ***

Comment 9

[mike.hitchcock]

Additional part of this bug - the "junk" directory does not record the count of
messages being redirected to the "junk" directory via the junk filter. The count
is updated and messages displayed if the "junk" directory is selected with the mouse

Comment 10

[Daniel Kies]

I am seeing Mike's additional problem regarding Junk folder miscounts too with
the 20040831 win32 nightly build.

Additionally, I often see that the message count in my Inbox is wrong. (It often
corrects itself after compacting the folders.)  Secondly, Mozilla mail/news
seems to "forget" which messages are marked as junk or not junk in the inbox,
junk folder, trash folder, and several user defined folders as well between
sessions.  (Deleting the relevant .msf files for those folders and letting the
20040831 nightly rebuild them does not help.)

Comment 11

[Mike Cowperthwaite]

*** Bug 257617 has been marked as a duplicate of this bug. ***

Comment 12

[Worcester12345]

The counts are still not working for me.

Thunderbird version 0.8 (20040902) .

Comment 13

[David :Bienvenu]

my tbird .8 build works fine for me, w.r.t. the trash counts. I double checked
that my fix was checked into the aviary branch as well.

Comment 14

[Worcester12345]

Here's a rundown:

Delete a message.
Go to trash, message is not showing there; so if I ever wanted to "undelete" or
"recover" it, I wouldn't be able to do so.
The size still says 4k as though the message were still there (which I believe
it is, but it just isn't showing).
If I "empty trash", or "compact", it has no effect on the size, display, or count.

Comment 15

[Worcester12345]

I meant to add that even closing and reopening won't always fix this. One thing
which will over 50% of the time is deleting another message. Then that second
message will show, and then "empty trash" will accurately empty and wipe out the
count.

Comment 16

[Daniel Kies]

The "additional problem" part of this bug mentioned in comment #9, comment #10,
and comment #14 is definitely still with us in the Mozilla suite win32 20040901
and 20040903 nightlies.

Comment 17

[Worcester12345]

This bug needs to be reopened, and marked as a blocker.

Comment 18

[David :Bienvenu]

I can't reproduce any of the problems.

Comment 19

[Daniel Kies]

Ok, I am testing the win32 20040903 nightly much more heavily, and I notice that
the additional problems reported earlier by myself and others are RESOLVED if I
delete all my .msf files while Mozilla is closed, letting the mail/news
application rebuild them later.

David, thank you for your work.  Much appreciated by all of us.  I will write
again if I notice that my note here turns out to be wrong upon further testing.

Comment 20

[Daniel Kies]

Damn.  I did speak too soon.  The "additional problems" reported above still
plague the win32 suite nightlies.  Sorry for the spam.

Comment 21

[Worcester12345]

This problem still showing up in this version: version 0.8 (20040903)

Comment 22

[Daniel Kies]

Still a problem with the win32 20040909 seamonkey build.  

The "additional problems" noted above often start for me AFTER a "Compact
Folders" command.  Then Mail/News seems to forget three things occassionally
(some of which only are visible after starting a new Mail/News session):  
1. what my column settings are in Junk and Trash, 
2. which mail is marked as "junk" (although junk filters behave correctly), and
3. the message count in the Inbox (miscounts usually begin as multiples of the
number of messages really there:  32 (real messages) > 64 messages (according to
the status bar or sidebar) > 96 messages eventually > 128 messages eventually,
etc.) I usually see the miscount increments after I switch between folders and
back to the Inbox.

This happens consistently for me.  Not theme related either.

Comment 23

[Worcester12345]

Still here in version 0.8 (20040908).

A restart of the program doesn't fix it either. Usually, it takes a new deletion
to show up, but only that deletion shows, and not prior deletions. Ditto for junk. 

Also just noticed today that messages marked as junk do not move back to inbox
when unmarked, when they used to before. Just including this in case it is related.

Comment 24

[Worcester12345]

Still having problems in this one: version 0.8 (20040910)

Comment 25

[Worcester12345]

What's up with unblocking this one? It is still open.