257152 - With JavaScript switched off, flag type deletion crashes

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Marc Schumann [:Wurblzap]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2

Undefined subroutine &main::deleteType called at editflagtypes.cgi line 360.

Reproducible: Always
Steps to Reproduce:
1. Switch JavaScript off
2. Go to editflagtypes.cgi
3. Click on some "delete" link

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Christian Reis]

Yeah.

Comment 3

[Christian Reis]

Comment on attachment 157162 [details] [diff] [review]
Patch

I'd rather we used deleteType consistently -- I suspect that was what Myk
intended originally -- using reserved words is evil.

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Using deleteType

> I'd rather we used deleteType consistently -- I suspect that was what Myk
> intended originally -- using reserved words is evil.

Do we want to harmonize editflagtypes by putting a trailing "...Type" to each
of the functions? New bug?

Comment 5

[Jouni Heikniemi]

Comment on attachment 157314 [details] [diff] [review]
Using deleteType

Kiko should get this since he looked at the previous patch as well.

Comment 6

[Christian Reis]

Comment on attachment 157314 [details] [diff] [review]
Using deleteType

>Index: editflagtypes.cgi
>-elsif ($action eq 'delete')         { &delete();        }
>+elsif ($action eq 'deleteType')     { deleteType();     

Keep the action as "delete" but have the function called deleteType -- yes,
it's a bit inconsistent, but we're only working around a perl limitation here
-- no need to expose it to the user. 

r=kiko on an updated patch, just seek approval.

Comment 7

[Christian Reis]

That way there are no template changes either.

Comment 8

[Marc Schumann [:Wurblzap]]

Attachment: Shortened patch

Comment 9

[Marc Schumann [:Wurblzap]]

(In reply to comment #6)
> r=kiko on an updated patch, just seek approval.

Comment 10

[Vlad Dascalu]

Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.8; previous revision: 1.7
done
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.7.2.1; previous revision: 1.7
done