257191 - Add NPN_InvokeDefault(), and rename NPN_Call() to NPN_Invoke() for consistency with other parts of the API

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Johnny Stenback (:jst)]

Per discussion in the plugin group, we decided to add an NPN_InvokeDefault()
method to the npruntime API, and while we're at it, we're renaming NPN_Call() to
NPN_Invoke() for the name to be consistent with the NPClass invoke hook, and
with the new method.

And while I was at it, I fixed a bug with getting properties exposed by plugins
when the plugin is accessed through the DOM.

Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Fix

Comment 2

[Johnny Stenback (:jst)]

*** Bug 254280 has been marked as a duplicate of this bug. ***

Comment 3

[Johnny Stenback (:jst)]

Attachment: Pass the right 'this' parameter to JS_CallFunctionValue() in nsHTMLExternalObjSH::Call()

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 157214 [details] [diff] [review]
Pass the right 'this' parameter to JS_CallFunctionValue() in nsHTMLExternalObjSH::Call()

Nit: hanging indent off by 3:

+      ok = ::JS_DefineElement(cx, obj, JSVAL_TO_INT(id), JSVAL_VOID, nsnull,
+				  nsnull, JSPROP_ENUMERATE);

Note for the plugin spec: we need to say what |this| binds to in JS, how it
follows the usual |this|-binding rules.  It could be that others make the
default method's |this| always be the callable object itself, or some other
"bound object" instead of what's determined by the usual JS rules.  Gotta get
agreement.

r+sr=[e-mail].

/be

Comment 5

[Johnny Stenback (:jst)]

Fix checked in on the trunk.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 157214 [details] [diff] [review]
Pass the right 'this' parameter to JS_CallFunctionValue() in nsHTMLExternalObjSH::Call()

a=asa for aviary checkin.

Comment 7

[Johnny Stenback (:jst)]

Fixed on the aviary branch as well.