257195 - Relative URIs in <svg:script> not working

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

We weren't passing a baseURI, so NS_NewURI was throwing out relative URIs.

Comment 1

[tor]

Attachment: pass base URI

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 157208 [details] [diff] [review]
pass base URI

that's gonna leak the nsIURI

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 157208 [details] [diff] [review]
pass base URI

Uh, it is? I don't think so. sr=jst

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 157208 [details] [diff] [review]
pass base URI

well I think so :)

GetBaseURI returns an already_AddRefed which ends up never being released.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 157208 [details] [diff] [review]
pass base URI

Duh, my eyes got stuck on 'uri', and I couldn't for the life of me figure out
how *that* could leak. Reverting my sr...

Comment 6

[tor]

Attachment: nsCOMPtr-foo

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 157217 [details] [diff] [review]
nsCOMPtr-foo

sr=jst

Comment 8

[tor]

Checked in.

Checking in nsSVGScriptElement.cpp;
/cvsroot/mozilla/content/svg/content/src/nsSVGScriptElement.cpp,v  <-- 
nsSVGScriptElement.cpp
new revision: 1.7; previous revision: 1.6
done