257211 - nsFormFillController::StartSearch leaks nsPasswordManager singleton

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsFormFillController::StartSearch leaks the nsPasswordManager singleton.  This
is ugly to fix because NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR expects a
function returning a raw AddRef'd pointer.  So I'll just fix it the ugly way, at
the call site.  And there's no need to bother with NS_IF_RELEASE when we would
have crashed the line before given a null pointer.

Steps to reproduce:
 * start Firefox
 * click in the search box
 * type Mozilla
 * hit enter
 * exit Firefox

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 157234 [details] [diff] [review]
patch

Can you instead change nsPasswordMangager::GetInstance to return
already_AddRefed<nsPasswordManager> and then use an nsCOMPtr in this code?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-09-01 17:40 -0700.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 157234 [details] [diff] [review]
patch

a=asa for branch checkin.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to AVIARY_1_0_20040515_BRANCH, 2004-09-14 13:46 -0700.