257230 - Debug output "GpiQueryBitmapBits failed" from nsDrawingSurfaceOS2.cpp

Status: VERIFIED FIXED

(Core Graveyard :: GFX: OS/2, defect)

Description

[Peter Weilbacher]

Not sure if this is intentionally left in, but if I see lots of output like this

   GpiQueryBitmapBits failed, error = 0x0
or 
   GpiQueryBitmapBits failed, error = 0x20A1

in a non-debug build on OS/2 when I redirect output into a file. Nothing special
is done when GpiQueryBitmapBits failed, so I guess this output is only good in a
debug build.

Comment 1

[Peter Weilbacher]

Attachment: Include debug output into #DEBUG statement

This just gets rid of the PMERROR debug output by placing it into an #ifdef
DEBUG statement present two lines further down. The patch should work for both
trunk and aviary.

In the debug build this will still get numerous lines, at least for Firefox,
because obviously each time the throbber is painted GpiQueryBitmapBits fails
(with error 0x0?!). But that should probably be put into a different bug.

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 157251 [details] [diff] [review]
Include debug output into #DEBUG statement

yeah, this one annoys me.

r=mkaply

I'm not even convinced it is a real error.

Comment 3

[Mike Kaply [:mkaply]]

I'm not convinced that PMERROR statement should be there at all...

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 157251 [details] [diff] [review]
Include debug output into #DEBUG statement

sr=blizzard (platform specific)
a=mkaply for 1.8a5 and 1.7

Comment 5

[Mike Kaply [:mkaply]]

Fix checked in everywhere.