lastused in logincookies should not have type timestamp

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
13 years ago
5 years ago

People

(Reporter: Tomas Kopal, Assigned: Tomas Kopal)

Tracking

unspecified
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4
Build Identifier: 

As discussed in bug 156834, timestamp type should be replaced by datetime. This
bug is against a lastused column in logincookies table. Patch will follow.

Reproducible: Always
Steps to Reproduce:
(Assignee)

Updated

13 years ago
Blocks: 156834
(Assignee)

Comment 1

13 years ago
Created attachment 157305 [details] [diff] [review]
Patch to replace timestamp with datetime type
(Assignee)

Updated

13 years ago
Attachment #157305 - Flags: review?
(Assignee)

Comment 2

13 years ago
Created attachment 157319 [details] [diff] [review]
Newer version of the patch

Updated checksetup.pl change to use existing function.
Attachment #157305 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #157319 - Flags: review?

Updated

13 years ago
Attachment #157305 - Flags: review? → review-

Updated

13 years ago
Attachment #157319 - Flags: review? → review+

Comment 3

13 years ago
Link for the MySQL documentation:

http://dev.mysql.com/doc/mysql/en/DATETIME.html
Assignee: justdave → Tomas.Kopal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
(Assignee)

Comment 4

13 years ago
Created attachment 157555 [details] [diff] [review]
V3 of the patch

Minor change in checksetup.pl to avoid annoying messages on every run, even
when the type does not actually change.
Attachment #157319 - Attachment is obsolete: true
(Assignee)

Comment 5

13 years ago
Comment on attachment 157555 [details] [diff] [review]
V3 of the patch

Sorry about changing this after review, but I tought it better be fixed.
Attachment #157555 - Flags: review?(vladd)
Waiting for review of v3 before approving.

Updated

13 years ago
Attachment #157555 - Flags: review?(vladd) → review+
Flags: approval? → approval+

Comment 7

13 years ago
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.302; previous revision: 1.301
done
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v  <--  CGI.pm
new revision: 1.3; previous revision: 1.2
done
Checking in Bugzilla/Auth/Login/WWW/CGI/Cookie.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI/Cookie.pm,v  <--
 Cookie.pm
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.