257303 - lastused in logincookies should not have type timestamp

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Tomas Kopal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4
Build Identifier: 

As discussed in bug 156834, timestamp type should be replaced by datetime. This
bug is against a lastused column in logincookies table. Patch will follow.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Tomas Kopal]

Attachment: Patch to replace timestamp with datetime type

Comment 2

[Tomas Kopal]

Attachment: Newer version of the patch

Updated checksetup.pl change to use existing function.

Comment 3

[Vlad Dascalu]

Link for the MySQL documentation:

http://dev.mysql.com/doc/mysql/en/DATETIME.html

Comment 4

[Tomas Kopal]

Attachment: V3 of the patch

Minor change in checksetup.pl to avoid annoying messages on every run, even
when the type does not actually change.

Comment 5

[Tomas Kopal]

Comment on attachment 157555 [details] [diff] [review]
V3 of the patch

Sorry about changing this after review, but I tought it better be fixed.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Waiting for review of v3 before approving.

Comment 7

[Vlad Dascalu]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.302; previous revision: 1.301
done
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v  <--  CGI.pm
new revision: 1.3; previous revision: 1.2
done
Checking in Bugzilla/Auth/Login/WWW/CGI/Cookie.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI/Cookie.pm,v  <--
 Cookie.pm
new revision: 1.2; previous revision: 1.1
done