257419 - checksetup.pl should quote database name in "show table status" command

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Marc Schumann [:Wurblzap]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2

Database names with e.g. dashes will crash checksetup.pl otherwise.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Christian Reis]

Comment on attachment 157402 [details] [diff] [review]
Patch

r=kiko if this works fine on any version of Perl and MySQL.

Comment 3

[Marc Schumann [:Wurblzap]]

> r=kiko if this works fine on any version of Perl and MySQL.

Perl doesn't care, interpolation inside `"' is done on variables, but not on quotes.

MySQL introduced quoting on backticks in version 3.23.6, so we're fine here as
well with Bugzilla requiring 3.23.41.

Note, though, that `"' will also work to quote identifiers if you run in ANSI
mode (from MySQL docs).

Comment 4

[Vlad Dascalu]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.301; previous revision: 1.300
done
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.289.2.4; previous revision: 1.289.2.3
done

Comment 5

[Dave Miller [:justdave]]

Is 2.16.x affected by this also?

Comment 6

[Vlad Dascalu]

Does anyone know if we need this for 2.16 as well? (see comment #5)

Comment 7

[Bradley Baetz (:bbaetz)]

I think that check was added post 2.16, wasn't it?