257561 - Go button should be removed when no location bar is present

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Richard Corbin]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040831
Firefox/0.9.1+

The "Go" button on the Navigation Toolbar should be disabled if the location bar
has been removed from / is not present on the Navigation Toolbar. With no
Location Bar the Go button is redundant.

Steps to Reproduce:
1. Ensure Go button is present (if not add it!)
2. Remove location bar from navigation toolbar using "customize..."

Expected Results:
Go button disabled / removed

Actual Results:
Go button is active yet does nothing.

---

(Perhaps) If a Go button is present, and the user tries to remove the location
bar, a dialog should pop-up asking if they would like the Go button to be
removed also. (or this could just be done automatically, though this may confise
users)

Comment 1

[Mike Connor [:mconnor]]

hmm, good catch.

Really, what we should do is remove the Go button when the location bar is removed.

Comment 2

[Richard Corbin]

Yes, I think it's best that the Go button is removed at the same time.

However, what should the default behaviour be when the location bar is *added*
to the toolbar again? Should the Go button also be added or should that decision
be left up to the user?

An example I can think of is as follows:

1. Grandma removes the location bar (by accident, perhaps!)
>> The go button is automagically removed

2. Grandma's grandson comes round and puts the location bar back for her. He
then goes back to his house.

3. Grandma is confused because the Go button has not re-appeared.

---

A silly example I guess, but was trying to get the point across that we can't
just remove things automatically and not put them back automatically. There
needs to be a more solid solution.

...

An idea I have, is a dialog box for when user adds location bar:

========================================
 Add "Go" button?
========================================
 Do you want to add the Go button also?

 [_] Do not show me this message again.

                             [Yes] [No]
----------------------------------------

Comment 3

[Ross Shannon]

Tweaking summary.

Comment 4

[miahz]

(In reply to comment #2)
> However, what should the default behaviour be when the location bar is *added*
> to the toolbar again?

Perhaps they should be added together (IE-style), which would also return it to
the default state.  This would ensure that Go comes back for anyone who expects
it.  The kind of people that know they don't want it are probably the kind of
people that customize and remove it anyway - so what's one extra drag-and-drop?

A dialog is probably unnecessary - nobody reads them.

Comment 5

[miahz]

To further reinforce their tethered nature, while in the Customize palette they
could be joined together in a wrapper as one draggable object.  But once on a
toolbar, could be arranged independantly in any manner just as before. 
Transparent safety for those who don't know, with all the old functionality for
those who do.  Though the single wrapper thing might cause some weirdness if Go
is put back in the palette without the Address Bar - not sure how that would work.

Comment 6

[Elmar Ludwig]

Closing as WFM, since the location bar and the go button are now one toolbar element, so this is not a problem any more.