257592 - version numbers hard-coded in brand.dtd

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

There are hard-coded version numbers in brand.dtd, which is pitiful, because you
can use the same langpack for 1.0, 1.0.1, etc without *any* updating at all
except for that string. And it's not a localizable string anyway, so there's no
need for it to be there. Patch coming up.

Comment 1

[Benjamin Smedberg]

Attachment: Hardcode version numbers, and also allow parts of the copyright notice to be localizable

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 157538 [details] [diff] [review]
Hardcode version numbers, and also allow parts of the copyright notice to be localizable

>-      <label id="version" value="&aboutVersion;"/>
>+#expand <label id="version" value="&aboutVersion; __MOZ_APP_VERSION__"/>

guaranteed, someone with a weird language will file a bug on this.  Cross that
bridge if it happens, I suppose (only other fix would be preprocessing the dtd
file, which is probably worse).

everything else looks good code-wise, but I think we should examine the
potential legal fallout of localizing the licenses before we commit this.

Comment 3

[Benjamin Smedberg]

I believe this is the arrangement that the licensing people agreed with (MPL/NPL
must stay in English, but the little notice that links to it can be translated),
but let's get their OK here.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 157538 [details] [diff] [review]
Hardcode version numbers, and also allow parts of the copyright notice to be localizable

a=[e-mail]. Make sure you update and rebuild in browser/  before landing
since I've tweaked some version numbers...

Comment 5

[Benjamin Smedberg]

Ben, with your new version numbers the "About Mozilla Firefox" box shows version
0.10. Is this correct? The user-agent shows 1.0 PR (NOT FINAL).

Comment 6

[Benjamin Smedberg]

Fixed on branch after IRC conversation with Ben (not yet applicable to trunk).

Comment 7

[Gervase Markham [:gerv]]

From a licensing point of view, that sounds right - MPL/NPL in English, but any
references/links to them can be translated.

Gerv