version numbers hard-coded in brand.dtd

RESOLVED FIXED

Status

()

Firefox
Build Config
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

({fixed-aviary1.0, l12y})

unspecified
fixed-aviary1.0, l12y
Points:
---
Bug Flags:
blocking-aviary1.0PR +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [have patch] - almost ready to land, need clarification from Ben - blocks l10n but not PR)

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
There are hard-coded version numbers in brand.dtd, which is pitiful, because you
can use the same langpack for 1.0, 1.0.1, etc without *any* updating at all
except for that string. And it's not a localizable string anyway, so there's no
need for it to be there. Patch coming up.
(Assignee)

Comment 1

14 years ago
Created attachment 157538 [details] [diff] [review]
Hardcode version numbers, and also allow parts of the copyright notice to be localizable
(Assignee)

Updated

14 years ago
Attachment #157538 - Flags: review?(mconnor)
(Assignee)

Updated

14 years ago
Flags: blocking-aviary1.0PR+
Whiteboard: [have patch] - need review anyone - blocks l10n but not PR
Comment on attachment 157538 [details] [diff] [review]
Hardcode version numbers, and also allow parts of the copyright notice to be localizable

>-      <label id="version" value="&aboutVersion;"/>
>+#expand <label id="version" value="&aboutVersion; __MOZ_APP_VERSION__"/>

guaranteed, someone with a weird language will file a bug on this.  Cross that
bridge if it happens, I suppose (only other fix would be preprocessing the dtd
file, which is probably worse).

everything else looks good code-wise, but I think we should examine the
potential legal fallout of localizing the licenses before we commit this.
Attachment #157538 - Flags: review?(mconnor)
Attachment #157538 - Flags: review+
Attachment #157538 - Flags: approval-aviary?
(Assignee)

Comment 3

14 years ago
I believe this is the arrangement that the licensing people agreed with (MPL/NPL
must stay in English, but the little notice that links to it can be translated),
but let's get their OK here.
Comment on attachment 157538 [details] [diff] [review]
Hardcode version numbers, and also allow parts of the copyright notice to be localizable

a=ben@mozilla.org. Make sure you update and rebuild in browser/  before landing
since I've tweaked some version numbers...
Attachment #157538 - Flags: approval-aviary? → approval-aviary+
(Assignee)

Comment 5

14 years ago
Ben, with your new version numbers the "About Mozilla Firefox" box shows version
0.10. Is this correct? The user-agent shows 1.0 PR (NOT FINAL).
(Assignee)

Updated

14 years ago
Whiteboard: [have patch] - need review anyone - blocks l10n but not PR → [have patch] - almost ready to land, need clarification from Ben - blocks l10n but not PR
(Assignee)

Comment 6

14 years ago
Fixed on branch after IRC conversation with Ben (not yet applicable to trunk).
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
From a licensing point of view, that sounds right - MPL/NPL in English, but any
references/links to them can be translated.

Gerv
You need to log in before you can comment on or make changes to this bug.