Closed
Bug 257596
Opened 21 years ago
Closed 21 years ago
remove nsIFocusTracker
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
35.31 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
The selection code uses an interface called nsIFocusTracker, which is
implemented by PresShell and just duplicates a couple of methods that are on
nsIPresShell. I propose simplifying the code by removing it (it also gets rid
of some silly code that gets the pres context from the focus tracker and then
gets the pres shell, not realizing that the pres shell _is_ the focus tracker).
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #157545 -
Flags: superreview?(roc)
Attachment #157545 -
Flags: review?(roc)
Attachment #157545 -
Flags: superreview?(roc)
Attachment #157545 -
Flags: superreview+
Attachment #157545 -
Flags: review?(roc)
Attachment #157545 -
Flags: review+
|
||
Comment 2•21 years ago
|
||
sorry for the spam.
May this fix take care of the irregular/unpredictable focusproblems in elements
or even in <body> ?
If that's a case this one would certainly be wanted in aviary.
|
|
Assignee | |
Comment 3•21 years ago
|
||
(In reply to comment #2)
> sorry for the spam.
> May this fix take care of the irregular/unpredictable focusproblems in elements
> or even in <body> ?
> If that's a case this one would certainly be wanted in aviary.
No, not at all. Just a removal of some redundant code in text selection.
Checked in on the trunk.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•