257602 - Add hooks to the JS engine to tell declaring resolves appart from non-declaring resolves.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Johnny Stenback (:jst)]

Bug 256932 made us walk through the document looking for random things by
name/id while declaring javascript variables, and also while looking up
constructors when creating new objects. We should have flags in the newResolve
hook to tell these types of resolves appart from normal ones, and avoid walking
the document in those cases.

Comment 1

[Brendan Eich [:brendan]]

Want this for PR1.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: proposed extension

Add JSRESOLVE_DECLARING, for var/const/function declaration prolog ops, and
JSRESOLVE_CONSTRUCTING, for constructor calls.

/be

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 157557 [details] [diff] [review]
proposed extension

Good for what ails us, the extra layer of subroutining for js_LookupProperty
should not hurt us.  Much ;-).

/be

Comment 4

[Brendan Eich [:brendan]]

s/JSRESOLVE_CONSTRUCTING/JSRESOLVE_CLASSNAME/ in comment 2.

/be

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 157557 [details] [diff] [review]
proposed extension

Oops, out of order LookupPropertyWithFlags call.  New patch in a trice.

/be

Comment 6

[Brendan Eich [:brendan]]

Attachment: better proposed extension

Should work on trunk.  Aviary/1.7 require some undoing of
gcc-strict-alias-warning fixes, jst says.

/be

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 157559 [details] [diff] [review]
better proposed extension

Argh.  Stand by.

/be

Comment 8

[Brendan Eich [:brendan]]

Attachment: best proposed extension

Ok, this is it!

/be

Comment 9

[Brendan Eich [:brendan]]

Comment on attachment 157561 [details] [diff] [review]
best proposed extension

Forgot to remove these two lines:

+			 if (cx->fp->flags & JSFRAME_CONSTRUCTING)
+			     flags |= JSRESOLVE_CLASSNAME;

Patch to remove these two lines coming up.

/be

Comment 10

[Brendan Eich [:brendan]]

Attachment: bestest proposed extension

Comment 11

[Johnny Stenback (:jst)]

Attachment: bestest proposed extension for the aviary branch

Comment 12

[Johnny Stenback (:jst)]

Attachment: The DOM side of the equation

Comment 13

[Johnny Stenback (:jst)]

Comment on attachment 157563 [details] [diff] [review]
bestest proposed extension

Works great (in combination with the DOM diff I just attached). sr=jst

Comment 14

[Brendan Eich [:brendan]]

Attachment: even better, expose API for XBL to avoid doc searches

BL patch in a minute.

/be

Comment 15

[Brendan Eich [:brendan]]

Attachment: Help XBL avoid document searches for scrollbar binding from quirky docs

This depends on attachment 157579 [details] [diff] [review], natch.

/be

Comment 16

[Brendan Eich [:brendan]]

Comment on attachment 157575 [details] [diff] [review]
The DOM side of the equation

Update the comment in the "then" clause to match, and r+sr=me.

/be

Comment 17

[Johnny Stenback (:jst)]

Comment on attachment 157579 [details] [diff] [review]
even better, expose API for XBL to avoid doc searches

sr=jst

Comment 18

[Johnny Stenback (:jst)]

Comment on attachment 157580 [details] [diff] [review]
Help XBL avoid document searches for scrollbar binding from quirky docs

sr=jst

Comment 19

[Johnny Stenback (:jst)]

Attachment: aviary version of "even better, expose API for XBL to avoid doc searches"

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 157580 [details] [diff] [review]
Help XBL avoid document searches for scrollbar binding from quirky docs

r=bzbarsky.  Looks good.

Comment 21

[Brendan Eich [:brendan]]

js/src and xbl/content/src changes checked into the trunk -- jst is doing the
dom chores there.

/be

Comment 22

[Johnny Stenback (:jst)]

DOM changes checked in on the trunk now too.

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 157575 [details] [diff] [review]
The DOM side of the equation

a=asa for branches checkin.

Comment 24

[Asa Dotzler [:asa]]

Comment on attachment 157579 [details] [diff] [review]
even better, expose API for XBL to avoid doc searches

a=asa for branches checkin.

Comment 25

[Asa Dotzler [:asa]]

Comment on attachment 157580 [details] [diff] [review]
Help XBL avoid document searches for scrollbar binding from quirky docs

a=asa for branches checkin.

Comment 26

[Johnny Stenback (:jst)]

All patches landed on the aviary branch.

Comment 27

[Brendan Eich [:brendan]]

I synced 1.7 js/src from aviary, after jst landed the js/src patch here on
aviary branch.  That was easy, cvs update -j without conflicts.

I also put the nsXBLBinding.cpp change on the 1.7 branch, which makes the 1.7
and aviary branch versions of that file match.

The DOM changes for document.all and global scope pollution quirks are not on
the 1.7 branch yet, but jst'll do those in due course.

/be

Comment 28

[Daniel Veditz [:dveditz]]

So should this one have "fixed1.7.x"? Is it waiting on the jst tasks mentioned
in comment 27 or are those tracked elsewhere?

Comment 29

[Johnny Stenback (:jst)]

Fixed on the 1.7 branch.