Closed Bug 257646 Opened 20 years ago Closed 13 years ago

improve JS unresponsive script dialog - log the warning in the JS Console, with URL

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 277713

People

(Reporter: bugzilla, Unassigned)

References

(
URL
)

Details

I just got the "Script warning: A script on this page is causing mozilla to run
slowly" dialog.

http://lxr.mozilla.org/mozilla/source/dom/src/base/nsJSEnvironment.cpp#525

it could need some work:
- the word "mozilla" shouldn't be hardcoded.
- buttons in the dialog should be Yes and No and not OK Cancel.
- this page is very vage.
- log the warning in the JS Console, with URL etc.
nsJSEnvironment is not part of the JS engine, as is obvious from the lxr URL.

At least the first two of your items are already covered by existing bugs.
Assignee: general → general
Component: JavaScript Engine → DOM
QA Contact: pschwartau → ian
Whiteboard: DUPEME
Bug 186279
Unresponsive script warning - should use Yes / No buttons, not OK / Cancel
Err, 186279 dups 78089
Bug 249086 fixed the Yes/No issue, but bug 78089 does kick around changes to the
message text and even has some ASCII art for UI..

Bug 145523 addresses using the brand name in the warning.

logging it in the JS Console could be nice and should not be so difficult. It's
being done a lot of places

here:
http://lxr.mozilla.org/mozilla/source/chrome/src/nsChromeRegistry.cpp#133

the patch that added console logging is here:
https://bugzilla.mozilla.org/attachment.cgi?id=178266
Also, I get this dialog when uploading files, even if there is no javascript on the page or javascript is turned off.  Worse, it comes up repeatedly every few seconds, so if I have to upload a file larger than a few hundred K, I have sometimes have to click "continue" several times.  There should be an option to turn off this dialog.
OS: Windows XP → All
Hardware: PC → All
Summary: JS unresponsive dialog could need some work → JS unresponsive script dialog needs work - log the warning in the JS Console, with URL
(In reply to comment #6)
> Also, I get this dialog when uploading files, even if there is no javascript on
> the page or javascript is turned off. 

Thomas your problem is probably bug 336602
Summary: JS unresponsive script dialog needs work - log the warning in the JS Console, with URL → improve JS unresponsive script dialog - log the warning in the JS Console, with URL
While working on a larger XUL project with a lot of js we are running very often into an unresponsive script warning. Finding the cause is a real pain so logging such an error would be VERY helpfull.

Instead of just log it in the javascript console I would also like to see a pref or an extension that shows the message in the unresponsive script dialog. Maybe after pressing a button "details".
One reason is that our XULRunner project usually should not show any error console to a user (we talk about ordinary ms office users which might be really scared by the console) but when running in such an error it would be great to let them click on "details", make a screenshot and send that to us :-)
What is needed to get this fixed? Whom do we have to support?
If you use Venkman, you will get prompted to debug from the slow script dialog.  But if you're working on a large XUL project, you definitely have the skills and background to fix this patch for everyone; Henrik's comment 5 shows good hints, and the Venkman source will have lots of information on finding out where the JS interpreter is when that dialog is posted.

#venkman on irc.mozilla.org will likely have folks who can help you with problems you might encounter extracting the interesting bits from the JS interpreter state.
I second comment #8 details should be available under a "Details" button or drop down. The current dialog is nice and simple but doesn't help anyone who has multiple tabs or windows open at the time.
Look at the number of bugs being entered with "unresponsive script" in the title.     The current dialog does not make it clear that the error is on the website, not in the browser code.  Otherwise, people would not be going to the trouble of entering a bug when they see this warning.  Listing the culprit URI in the dialog and putting the details in the error console would reduce noise in bugzilla by pointing them to the right place to complain.
Assignee: general → nobody
QA Contact: ian → general
The new dialog in Firefox 3.5 shows the URL and when Firebug is open I can also debug the script.

The warning is still no logged in the JS Console, but for me this is not necessary.

@Henrik: Do you think this is fixed with the current behaviour?
(In reply to comment #13)
> The new dialog in Firefox 3.5 shows the URL and when Firebug is open I can also
> debug the script.
> 
> The warning is still no logged in the JS Console, but for me this is not
> necessary.

It would be nice to know what fixed it, but I can't find the bug. I also noticed this in the last couple days. 

OT, do we know whether this also improved in thunderbird?
(In reply to comment #13)
> @Henrik: Do you think this is fixed with the current behaviour?

Seems ok in 3.5 now
(of what's left) duplicate of bug 277713 ?
Whiteboard: DUPEME
duping forward to bug 277713, which has WIP patch - but needs a boost
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.