257721 - nsPresShell::PostAttributeChange crashes

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[[e-mail]]

roc suggested I use this to set/clear the disabled attribute on scrollbars.
Unfortunately it allocates some memory without constructing it.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Using placement new as suggested by brendan.

Note that HandlePostedAttributeChanges already calls the destructor.

Comment 2

[[e-mail]]

Comment on attachment 157663 [details] [diff] [review]
Proposed patch

Since it was you who asked me to use it in the first place ;-)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 157663 [details] [diff] [review]
Proposed patch

How does this change anything?	Or do you want nsAttributeChangeRequest to have
a nontrivial constructor in the future?

Comment 4

[[e-mail]]

Yes, I missed off some detail as usual...

The constructor is nontrivial because the structure contains an nsAutoString.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 157663 [details] [diff] [review]
Proposed patch

containing an nsAutoString is evil... we should change that to some other sort
of string. but this patch is good.

Comment 6

[[e-mail]]

Fix checked in.