257722 - No visual feedback when clicking on scrollbarbutton in autocomplete popups (no depressed state)

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Martijn Wargers (dead)]

See for example the url bar. Open the url bar autocomplete popup. Click on the
scrollbarbutton (up or down). You won't see that the scrollbarbutton is clicked
upon. This is different from a 'normal' scrollbar. 

I've even seen this bug in Firefox0.7, so if this is a regression, it is some
time ago.
I don't think this is a simple theme issue. I've played with some css rules for
scrollbars. I can get :hover rules to apply for scrollbarbuttons in autocomplete
popups, but not :active rules.

Comment 1

[Niall Glynn]

this bug is present in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0 also.

Comment 2

[David P James]

Mass edit: Changing QA to default QA Contact

Comment 3

[David P James]

Mass edit: Setting correct QA for location bar/autocomplete. My bad. I forgot I had once been Autocomplete QA too. Hmm, why can't I just set the QA of bugs to the default QA of the component in a mass edit rather than having to do it manually...?

Comment 4

[Martijn Wargers (dead)]

Attachment: patch

This fixes it for me.
I'm wondering why Seamonkey doesn't have this problem, though.

Comment 5

[[e-mail]]

(In reply to comment #4)
>I'm wondering why Seamonkey doesn't have this problem, though.
SeaMonkey Modern is OK, but I see it with both Classic and Winstripe themes.

Comment 6

[[e-mail]]

Comment on attachment 289488 [details] [diff] [review]
patch

>+      <xul:tree anonid="tree" class="autocomplete-tree plain" hidecolumnpicker="true" flex="1" style="-moz-user-focus: ignore !important;">
This belongs in xul.css (there's a section for autocomplete).

>-    <content onmousedown="event.preventDefault()">
>+    <content>
Please apply the equivalent fix to xpfe's autocompelte.xml for TB/SM.

Comment 7

[Martijn Wargers (dead)]

Attachment: firefox patch

Comment 8

[Martijn Wargers (dead)]

Attachment: seamonkey patch

This one is untested, I don't have a Seamonkey tree yet (sorry).
(I though xpfe was going away or something, last time you said I shouldn't bother with xpfe, or something like that).

Comment 9

[[e-mail]]

Comment on attachment 290133 [details] [diff] [review]
seamonkey patch

Works fine.

FYI this is one of the few pieces of XPFE chrome that SeaMonkey still uses (the other two are download manager and windows hooks).

Comment 10

[[e-mail]]

Comment on attachment 290132 [details] [diff] [review]
firefox patch

> .autocomplete-tree {
>+  -moz-user-focus: ignore;
>   -moz-binding: url("chrome://global/content/bindings/autocomplete.xml#autocomplete-tree");
> }
Nit: We normally have the -moz-binding in first (compare e.g. radiogroup).

Comment 11

[Martijn Wargers (dead)]

Comment on attachment 290132 [details] [diff] [review]
firefox patch

Ok, thanks, I'll change the order on check-in.

Comment 12

[Reed Loden [:reed]]

Comment on attachment 290133 [details] [diff] [review]
seamonkey patch

You don't need approval for SeaMonkey-only patches.

Comment 13

[Martijn Wargers (dead)]

Checking in autocomplete.css;
/cvsroot/mozilla/xpfe/components/autocomplete/resources/content/autocomplete.css
,v  <--  autocomplete.css
new revision: 1.12; previous revision: 1.11
done
Checking in autocomplete.xml;
/cvsroot/mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml
,v  <--  autocomplete.xml
new revision: 1.159; previous revision: 1.158
done

Seamonkey patch checked in.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 290132 [details] [diff] [review]
firefox patch

a=beltzner on behalf of drivers

Comment 15

[Martijn Wargers (dead)]

Checking in xul.css;
/cvsroot/mozilla/toolkit/content/xul.css,v  <--  xul.css
new revision: 1.111; previous revision: 1.110
done
Checking in widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.x
ml
new revision: 1.91; previous revision: 1.90
done

Checked into Firefox.

Comment 16

[Szabolcs Horvát]

It is very nice that this is fixed!

But this was not the only place in the UI which had this problem.  See for example the "More Actions" drop-down in the new version of Gmail.  There is still no depressed state for the scrollbar or scroll arrows.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112805 Minefield/3.0b2pre ID:2007112805

Comment 17

[Martijn Wargers (dead)]

The drop-down in the new version of Gmail is not a drop-down in the sense of a select drop down.
I guess Gmail is using event.preventDefault() in some way on mousedown, so this is not a Firefox problem, but more a problem with the site.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d0dcc06751f
No visual feedback when clicking on scrollbarbutton in autocomplete popups (no depressed state), r=neil, SeaMonkey-only