257765 - Replies to private comments should default to being private

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Marc Schumann [:Wurblzap]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7) Gecko/20040707 Firefox/0.9.2

I think it might be a good idea to check the "private" checkbox for the new
comment when pressing "reply" on a private comment. This would reduce the risk
of disclosing confidential information.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Check the "private" checkbox for the new comment when replying to a private comment

Comment 2

[Christian Reis]

Comment on attachment 157708 [details] [diff] [review]
Check the "private" checkbox for the new comment when replying to a private comment

>+++ patched/template/en/default/bug/comments.html.tmpl	>+      [% ELSE %]
>+        <input type="hidden" id="isprivate-[% count 

Not much point in having a hidden field if it has no value, or is there?

>   [% IF Param("insidergroup") && UserInGroup(Param("insidergroup")) %]
>-    <input type="checkbox" name="commentprivacy" value="1"> Private
>+    <input type="checkbox" name="commentprivacy" id="commentprivacy"
>+           value="1"> Private

That's odd. If the default value is 1, why isn't it already always on?

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Auto-check "private" checkbox

(In reply to comment #2)
> >+	    <input type="hidden" id="isprivate-[% count 
> 
> Not much point in having a hidden field if it has no value, or is there?

The point is to have a field looking like an unchecked checkbox. (field.checked
evaluates to false.)

But I see that this is not really very readable. So I removed the field, and
the JavaScript code looking at the field now applies only if the real checkbox
is available.

> >-	<input type="checkbox" name="commentprivacy" value="1"> Private
> 
> That's odd. If the default value is 1, why isn't it already always on?

The value attribute of a checkbox is what's being sent to the server as its
form value, if checked. The state of checkedness is given by the checked
attribute.

Comment 4

[Christian Reis]

Comment on attachment 158004 [details] [diff] [review]
Auto-check "private" checkbox

Looks good and simple enough to make a quick cut.

Comment 5

[Christian Reis]

One note: should we really use "newcommentprivacy" as the id but
"commentprivacy" as the name? I think they should be consistently equal; I can
fix this when checking in, however, so let's seek approval.

Comment 6

[Marc Schumann [:Wurblzap]]

(In reply to comment #5)
> One note: should we really use "newcommentprivacy" as the id but
> "commentprivacy" as the name? I think they should be consistently equal; I can
> fix this when checking in, however, so let's seek approval.

I agree.
I'd prefer newcommentprivacy, but that has impact on process_bug.cgi and all, so
I'd say we'd better stick with commentprivacy for now.

Comment 7

[Dave Miller [:justdave]]

Sure.  Let's go ahead and throw this on 2.18 while we still can. :)  This is
enough of a "Right Thing to do" that it should be there.

Comment 8

[Vlad Dascalu]

Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v
 <--  comments.html.tmpl
new revision: 1.11.2.1; previous revision: 1.11
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.40.2.2; previous revision: 1.40.2.1
done

Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v
 <--  comments.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.44; previous revision: 1.43
done

Comment 9

[realmailorderbride]

Find the best bride by mail is now possible. We offer you a beautiful https://realmailorderbride.com/russian. Caring girls want dating. Come on our site you will surely meet your fate.