257834 - firefox logo and wizard panel clipped in Linux installer (minor)

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Jeremy M. Dolan]

Today's aviary Linux installer.

The installer window is created with a width of 540px. The Mozilla logo in the
upper-right on most screens is slightly clipped. With a window size of 550px, it
appears perfect (larger sizes create too much blank space to the right of the
image).

Will attach a screen capture.

Comment 1

[Jeremy M. Dolan]

Attachment: screen capture of clipped logo

Comment 2

[sairuh (rarely reading bugmail)]

*** Bug 259718 has been marked as a duplicate of this bug. ***

Comment 3

[sairuh (rarely reading bugmail)]

->bryner, but punt as needed.

I've also noticed that the top and bottom portions of the installation wizard
are clipped. would this be related, or a separate issue? screenshot coming up.

Comment 4

[sairuh (rarely reading bugmail)]

Attachment: clipped portions of install wizard

I had run a custom installation, and noticed that the top portion, "Setup Type"
and the listbox in the middle portion are clipped (chopping off some of the
text).

Comment 5

[sairuh (rarely reading bugmail)]

what I see in comment 4 is a regression (not sure about the logo aspect), so
nominating.

Comment 6

[chris hofmann]

think we have run out of time for this in 1.0.

Comment 7

[Asa Dotzler [:asa]]

*** Bug 265468 has been marked as a duplicate of this bug. ***

Comment 8

[Asa Dotzler [:asa]]

I think we need to reconsider this. Do we care so little about Linux that we
want our users' first experience to be this awful? 

Comment 9

[chris hofmann]

sounds like a fix might be coming

Comment 10

[Brian Ryner (not reading)]

Attachment: remove DOS line endings in installer.inc

The extra CR character was causing gtk to insert extra linebreaks.  I think we
should remove the DOS line endings in CVS; Windows seems to deal with this ok
(I tested the installer and there were no problems with these strings).

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 162938 [details] [diff] [review]
remove DOS line endings in installer.inc

a=asa for aviary checkin pending review.

Comment 12

[Benjamin Smedberg]

Comment on attachment 162938 [details] [diff] [review]
remove DOS line endings in installer.inc

Did I check this in with DOS endings to begin with? that sucks.

Comment 13

[Brian Ryner (not reading)]

fixed on branch (I don't think this problem is present on the trunk)

Comment 14

[Tracy Walker [:tracy]]

Verified on Firefox linux branch build 2004-10-22-09-0.9

Items are no longer misalinged and/or chopped off in the installer dialogs

Comment 15

[Tracy Walker [:tracy]]

This bug had become two issues. The later of which is fixed.

However, the orginal bug of the logo cut off is still present (see initial
attachment).  Resize the window to make it wider, then the full logo is shown.

Reopening and removing flags/keywords regarding aviary blockage. This is, as
orginally reported a minor issue. 

Comment 16

[Asa Dotzler [:asa]]

This bug seems to have an aviary branch checkin associated with it. If this has
landed on the aviary branch (as much as it's going to for 1.0) can you please
add the "fixed-aviary1.0" keyword? Thanks.

Comment 17

[sairuh (rarely reading bugmail)]

(In reply to comment #15) 
> However, the orginal bug of the logo cut off is still present (see initial
> attachment).  Resize the window to make it wider, then the full logo is shown.

the logo issue is now fixed as part of bug 265826. should this be re-resolved?

Comment 18

[Brian Ryner (not reading)]

re-resolving