257877 - replacement content isn't rendered if gkplugin.dll isn't present

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[timeless]

steps:
1. rename gkplugin.dll (gkplugin.dul)
2. run mozilla
3. load url
4. if you see 'hi' then your build is patched or you failed to rename
gkplugin.so/...

When I do it, I get nothing.
for various reasons I need to be able to not ship gkplugin.dll and still have a
fairly compliant web browser.

Comment 1

[timeless]

Attachment: handle replacement content w/o gkplugin -uwp

the main change is to nsObjectFrame::Reflow, the problem was that the code
returned early...

the change to nsObjectFrame::DidReflow is to avoid asserting in
mInstanceOwner->GetWindow when there's no plugin.

nsObjectFrame::GetPluginInstance/nsObjectFrame::GetInstance is just simplifying
code.

Comment 2

[timeless]

Attachment: handle replacement content w/o gkplugin -up

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

r=jst, assuming this doesn't break loading normal plugins (which it really
looks like it shouldn't, but worth testing).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

sr=bzbarsky

Comment 5

[timeless]

mozilla/layout/html/base/src/nsObjectFrame.cpp 	1.468 	

Comment 6

[timeless]

Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

the landing is:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/layout/html/base/src/nsObject
Frame.cpp&rev=1.468

(there's one change, approved by jst, from the posted patch, to use an nsCOMPtr
and null check the result of GetPluginInstance).

we don't intend to ship gkplugin from our product when we move to 17x and
therefore need this change.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

a=mkaply for 1.7

Comment 8

[Daniel Veditz [:dveditz]]

If this is checked into the 1.7 branch please add the fixed1.7.5 keyword