replacement content isn't rendered if gkplugin.dll isn't present

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({fixed1.7.5})

Trunk
x86
Windows XP
fixed1.7.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

14 years ago
steps:
1. rename gkplugin.dll (gkplugin.dul)
2. run mozilla
3. load url
4. if you see 'hi' then your build is patched or you failed to rename
gkplugin.so/...

When I do it, I get nothing.
for various reasons I need to be able to not ship gkplugin.dll and still have a
fairly compliant web browser.
(Assignee)

Comment 1

14 years ago
Created attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

the main change is to nsObjectFrame::Reflow, the problem was that the code
returned early...

the change to nsObjectFrame::DidReflow is to avoid asserting in
mInstanceOwner->GetWindow when there's no plugin.

nsObjectFrame::GetPluginInstance/nsObjectFrame::GetInstance is just simplifying
code.
(Assignee)

Comment 2

14 years ago
Created attachment 157777 [details] [diff] [review]
handle replacement content w/o gkplugin -up
(Assignee)

Updated

14 years ago
Attachment #157776 - Flags: superreview?(bzbarsky)
Attachment #157776 - Flags: review?(jst)
Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

r=jst, assuming this doesn't break loading normal plugins (which it really
looks like it shouldn't, but worth testing).
Attachment #157776 - Flags: review?(jst) → review+
Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

sr=bzbarsky
Attachment #157776 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Comment 5

14 years ago
mozilla/layout/html/base/src/nsObjectFrame.cpp 	1.468 	
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

14 years ago
Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

the landing is:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/layout/html/base/src/nsObject
Frame.cpp&rev=1.468

(there's one change, approved by jst, from the posted patch, to use an nsCOMPtr
and null check the result of GetPluginInstance).

we don't intend to ship gkplugin from our product when we move to 17x and
therefore need this change.
Attachment #157776 - Flags: approval1.7.x?

Comment 7

14 years ago
Comment on attachment 157776 [details] [diff] [review]
handle replacement content w/o gkplugin -uwp

a=mkaply for 1.7
Attachment #157776 - Flags: approval1.7.x? → approval1.7.x+
If this is checked into the 1.7 branch please add the fixed1.7.5 keyword
(Assignee)

Updated

14 years ago
Keywords: fixed1.7.5
You need to log in before you can comment on or make changes to this bug.