Closed Bug 257948 Opened 21 years ago Closed 21 years ago

several idl files have #endif without #ifdef

Categories

(Core Graveyard :: Profile: BackEnd, defect)

Product:
Core Graveyard
Component:
Profile: BackEnd
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Biesinger, Assigned: csthomas)

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
4.33 KB, patch
dveditz
: review+
neil
: superreview+
Details | Diff | Splinter Review
/home/chb/mozilla/mozilla/profile/public/nsIProfile.idl:89: Error: More #endif's than #if's found. /home/chb/mozilla/mozilla/profile/public/nsIProfileChangeStatus.idl:144: Error: More #endif's than #if's found. /home/chb/mozilla/mozilla/profile/public/nsIProfile.idl:89: Error: More #endif's than #if's found. /home/chb/mozilla/mozilla/profile/public/nsIProfileInternal.idl:156: Error: More #endif's than #if's found. /home/chb/mozilla/mozilla/profile/public/nsIProfileStartupListener.idl:61: Error: More #endif's than #if's found. /home/chb/mozilla/mozilla/widget/public/nsIAppShell.idl:119: Error: More #endif's than #if's found.
Attachment #157858 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #157858 - Flags: review?(dveditz)
Status: NEW → ASSIGNED
OS: Linux → All
I'd think it would be better to remove that endif lines, they are not usual style for .idl. the resulting .h file will get such include guards by xpidl anyway.
Attachment #157858 - Attachment is obsolete: true
Attachment #157858 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #157858 - Flags: review?(dveditz)
Attachment #157885 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #157885 - Flags: review?(dveditz)
Attachment #157885 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment on attachment 157885 [details] [diff] [review] Patch v2 r=dveditz
Attachment #157885 - Flags: review?(dveditz) → review+
checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: r?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: