History Window: View|Sorted by menu items do not work

RESOLVED FIXED

Status

()

Core
History: Global
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Stefan Borggraefe, Assigned: Vidar Haarr (not reading bugmail))

Tracking

({fixed-seamonkey1.0, regression})

Trunk
fixed-seamonkey1.0, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

13 years ago
Instead when you select one of them, the following error is displayed on the
JavaScript Console:

Error: column.parentNode has no properties
Source File: chrome://global/content/nsTreeSorting.js
Line: 67

Tested with a Linux trunk build from yesterday.
(Reporter)

Comment 1

13 years ago
Created attachment 157847 [details] [diff] [review]
Proposed Fix
(Reporter)

Updated

13 years ago
Attachment #157847 - Flags: review?(varga)

Comment 2

13 years ago
The problem is that nsTreeSorting.js was initially developed as a generic
utility, IIRC.
So you shouldn't use |document.getElementById('historyTree')|

Updated

13 years ago
Attachment #157847 - Flags: review?(jan) → review-
(Assignee)

Comment 3

12 years ago
Created attachment 197528 [details] [diff] [review]
version 0.1
Attachment #157847 - Attachment is obsolete: true
Attachment #197528 - Flags: review?(neil.parkwaycc.co.uk)

Comment 4

12 years ago
Comment on attachment 197528 [details] [diff] [review]
version 0.1

I'm wondering whether we should rename SortColumn to SortColumnElement and add
a new SortColumn method to handle the history tree.
Attachment #197528 - Flags: review?(neil.parkwaycc.co.uk) → review?(Jan.Varga)

Comment 5

12 years ago
(In reply to comment #4)
> (From update of attachment 197528 [details] [diff] [review] [edit])
> I'm wondering whether we should rename SortColumn to SortColumnElement and add
> a new SortColumn method to handle the history tree.
> 

Yeah, SortColumn() will just call document.getElementById() and SortColumnElement()

r=varga

Updated

12 years ago
Attachment #197528 - Flags: review?(Jan.Varga) → review-
(Assignee)

Comment 6

12 years ago
Created attachment 198582 [details] [diff] [review]
version 0.2

Something like this?
Assignee: Stefan.Borggraefe → vhaarr+bmo
Status: NEW → ASSIGNED
Attachment #198582 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #198582 - Flags: review?(Jan.Varga)
(Assignee)

Updated

12 years ago
Attachment #197528 - Attachment is obsolete: true

Updated

12 years ago
Attachment #198582 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Comment 7

12 years ago
Comment on attachment 198582 [details] [diff] [review]
version 0.2

yes
Attachment #198582 - Flags: review?(Jan.Varga) → review+

Comment 8

12 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 9

12 years ago
Seamonkey-only portion of fix checked in to the 1.8 branch.
Whiteboard: fixed-seamonkey1.0
Keywords: fixed-seamonkey1.0
Whiteboard: fixed-seamonkey1.0
You need to log in before you can comment on or make changes to this bug.