258035 - document port argument of nsIDNSRecord::getNextAddr

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

since it took me some time to realize why a port is passed here and what it
means, the argument should be documented. will attach a patch in a second.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 157904 [details] [diff] [review]
patch

>+     * @param port A port number to initialize the PRNetAddr with.

Can you also name the parameter |aPort| instead, and move the
definition under aPort (see examples in nsIDNSService.idl).  Thx!

r+sr=darin

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: final patch

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in netwerk/dns/public/nsIDNSRecord.idl;
/cvsroot/mozilla/netwerk/dns/public/nsIDNSRecord.idl,v  <--  nsIDNSRecord.idl
new revision: 1.4; previous revision: 1.3
done

Comment 5

[benc]

V/fixed. Thanks for pasting the cvs checkin output here.