Closed
Bug 258035
Opened 21 years ago
Closed 21 years ago
document port argument of nsIDNSRecord::getNextAddr
Categories
(Core :: Networking, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.8alpha4
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file, 1 obsolete file)
|
1.20 KB,
patch
|
Details | Diff | Splinter Review |
since it took me some time to realize why a port is passed here and what it
means, the argument should be documented. will attach a patch in a second.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #157904 -
Flags: superreview?(darin)
Attachment #157904 -
Flags: review?(darin)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha4
|
||
Comment 2•21 years ago
|
||
Comment on attachment 157904 [details] [diff] [review]
patch
>+ * @param port A port number to initialize the PRNetAddr with.
Can you also name the parameter |aPort| instead, and move the
definition under aPort (see examples in nsIDNSService.idl). Thx!
r+sr=darin
Attachment #157904 -
Flags: superreview?(darin)
Attachment #157904 -
Flags: superreview+
Attachment #157904 -
Flags: review?(darin)
Attachment #157904 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #157904 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•21 years ago
|
||
Checking in netwerk/dns/public/nsIDNSRecord.idl;
/cvsroot/mozilla/netwerk/dns/public/nsIDNSRecord.idl,v <-- nsIDNSRecord.idl
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
V/fixed. Thanks for pasting the cvs checkin output here.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•