258088 - search icons corrupted

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040905
Firefox/1.0 PR (NOT FINAL)

amazondotcom.png is corrupted
dictionary.png is corrupted
yahoo.gif is partially corrupted

repro:
open FF
click on searchbar icon
see missing/corruped icons

Comment 1

[Peter van der Woude [:Peter6]]

regression from bug 257242

->?PR1

Comment 2

[Peter van der Woude [:Peter6]]

Attachment: yahoo.gif

att. the Yahoo icon that they have been using for quite some time.
(optimised gif format)
The one that's used up till now is antique.

Comment 3

[Pierre Chanial]

what a dumb I am!!
I forgot to add the icons as binary...
sorry...

Someone with cvs admin privileges has to do:
cd mozilla/browser/locales/en-US/searchplugins
cvs admin -kb amazondotcom.png dictionary.png yahoo.gif

Comment 4

[Pierre Chanial]

ah!
Anyone can with cvs access can do cvs admin.
Peter: thanks for the quick bug report!

Peter, your gif file is 600 bytes bigger than the one we ship. That's huge!

Comment 5

[Peter van der Woude [:Peter6]]

> Peter, your gif file is 600 bytes bigger than the one we ship. That's huge!
I know, but I left all colors in that are used by Yahoo.
Further compression/optimisation lead to an ugly image with a blob i/o the
questionmark next to the big Y

Comment 6

[Peter van der Woude [:Peter6]]

Attachment: yahoo.gif truely optimised

who's the dumbo ?
here's the right yahoo.gif in optimized format (i uploaded the wrong one
before)
size down to 89 bytes for the same image quality

Comment 7

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040906
Firefox/1.0 PR (NOT FINAL)

->VERIFIED