258149 - Find toolbar needs a keyboard shortcut to close it (like ctrl+f opens it)

Status: VERIFIED DUPLICATE of bug 250587

(Toolkit :: Find Toolbar, enhancement)

Description

[disgruntled.toaster]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

see summary :)  What keyboard shortcuts are remaining anyways?

Reproducible: Always
Steps to Reproduce:
1. Ctrl+f to open find toolbar
2. Realize that you don't have anything to find
3. Try ctrl+???? (what's left) to close toolbar
Actual Results:  
End up pulling out hair and using mouse instead to close it


Expected Results:  
Show a keyboard shortcut (ctrl+???) to close the toolbar on the tooltip for the
close button.

Comment 1

[Radek 'sysKin' Czyz]

how about escape?

Comment 2

[Justin Kerk]

Escape works here.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040906 Firefox/1.0

Comment 3

[Andy Grover]

This needs to be discoverable.

Comment 4

[Asaf Romano (gone)]

Escape works only when the find toolbar is focused.

Comment 5

[Tom Zickel]

Attachment: this patch makes the ctrl-f toggle the findbar (if it's focused currently)

This patch i've written with the help of Silver ([e-mail]),
makes the ctrl-f toggle the find bar (just like ctrl-j toggles the download
manager), when it's focused.

If it's not focused it retains the normal behaivour (gives back focus, meaning
ctrl-f twice will close it).

This is my first patch ever submitted so dont go down **** me :)

Comment 6

[Mike Connor [:mconnor]]

already WONTFIXed by blake, for a really good reason.  See
https://bugzilla.mozilla.org/show_bug.cgi?id=250587#c17

*** This bug has been marked as a duplicate of 250587 ***

Comment 7

[:deanis74]

If the key behaves differently depending on whether the find field is focused,
why not just use the existing Esc shortcut to close it?