Closed
Bug 258179
Opened 20 years ago
Closed 20 years ago
winEmbed includes unused headers
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
5.80 KB,
patch
|
dougt
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
winEmbed includes several headers it doesn't use, particularly unfrozen ones. I have a patch to remove them.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #158019 -
Flags: superreview?(bzbarsky)
Attachment #158019 -
Flags: review?(dougt)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Comment 2•20 years ago
|
||
Comment on attachment 158019 [details] [diff] [review] patch sr=bzbarsky
Attachment #158019 -
Flags: superreview?(bzbarsky) → superreview+
Comment 3•20 years ago
|
||
Comment on attachment 158019 [details] [diff] [review] patch assuming everything compiles, r=dougt
Attachment #158019 -
Flags: review?(dougt) → review+
Assignee | ||
Comment 4•20 years ago
|
||
Checking in WebBrowserChrome.cpp; /cvsroot/mozilla/embedding/tests/winEmbed/WebBrowserChrome.cpp,v <-- WebBrowserChrome.cpp new revision: 1.49; previous revision: 1.48 done Checking in WebBrowserChrome.h; /cvsroot/mozilla/embedding/tests/winEmbed/WebBrowserChrome.h,v <-- WebBrowserChrome.h new revision: 1.19; previous revision: 1.18 done Checking in winEmbed.cpp; /cvsroot/mozilla/embedding/tests/winEmbed/winEmbed.cpp,v <-- winEmbed.cpp new revision: 1.75; previous revision: 1.74 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•