258265 - installer strings in defines.inc are charset-ambiguous

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Benjamin Smedberg]

It turns out that the installer strings in defines.inc are charset-ambiguous. On
linux, they should be UTF8, and on windows, they must pick a windows standard
encoding (UTF8 is not an option because we cannot depend on MSLU). The solution
is to convert from UTF8 to the arbitrary encoding at build time, using iconv.
Patch forthcoming.

Comment 1

[Benjamin Smedberg]

Attachment: Use iconv for windows at build time

Comment 2

[Benjamin Smedberg]

Comment on attachment 158552 [details] [diff] [review]
Use iconv for windows at build time

This is, I believe, the last change before the Firefox l10n freeze. I need to
review the blocking? list before declaring it so.

Comment 3

[Benoit]

There is another defines.inc in toolkit. It contains only one line: the one of
the locale. 

Unfortunately, the french word for french (français) is not US-ASCII neither.
Will it receive the same treatment? Or, if that is feasable, could we completely
get rid of this file?

Comment 4

[Benjamin Smedberg]

> There is another defines.inc in toolkit. It contains only one line: the one of
> the locale. 

This file is UTF-8. This patch makes all the .inc files UTF8.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 158552 [details] [diff] [review]
Use iconv for windows at build time

a=asa (on behalf of the aviary team) for checkin to the aviary branch.