Closed
Bug 258300
Opened 20 years ago
Closed 20 years ago
Many character encoding is unselectable in setting of Default Character Encoding.
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha4
People
(Reporter: hub-san, Assigned: dbaron)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.44 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040904 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040904 I cannot select character encoding of language setting which I want because scroll bar is gone. This problem happens at both "Languages" of "Navigator" category and "Message Display" of "Mail & Newsgroups" category. Reproducible: Always Steps to Reproduce: 1. Goto Mozilla->Preferences...->Navigator->Languages. 2. Select Character Encoding: -> Default Character Encoding. (in Navigator category) Actual Results: Many character encoding is unselectable because scroll bar is gone. I cannot select character encoding of language setting which I want. Expected Results: All character encoding is selectable by using scroll bar. I can select character encoding of language setting which I want. On MacOSX10.2.8, I confirmed this problem on Mozilla 2004-09-05-08-trunk build(Classic theme). But, Mozilla 2004-09-04-08-trunk didn't have this problem. Then, I confirmed this problem on Mozillla 2004-09-05-03-trunk build(Linux gtk2+xft). But, Mozilla 2004-09-04-03-trunk(gtk2+xft) didn't have this problem. It seemed that this bug occurred between 20040903 and 20040904. I searched CVS checkins of last three days. Is this problem caused by bug 72747? Or bug 252326 or bug 257920 or bug 250342?
Keywords: regression
Assignee | ||
Comment 2•20 years ago
|
||
Checkin range is roughly: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-09-04+06%3A00&maxdate=2004-09-05+04%3A00&cvsroot=%2Fcvsroot
Assignee | ||
Comment 3•20 years ago
|
||
It may have something to do with the parsing of the style attribute on the xul:hbox inside the menupopup inside the menulist. (Although there is a chance that I could be seeing two separate bugs -- one in style data computation and one in serialization.)
Assignee | ||
Comment 4•20 years ago
|
||
A pull-by-date build at 2004-09-04 17:00 -0700 doesn't show the bug.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 5•20 years ago
|
||
Bizarrely enough, this seems to fix the bug. I don't know: (1) why parsing style attributes in XBL involves serialization (2) why there wasn't a CSS error when the serialization was reparsed
Assignee: jag → dbaron
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #158160 -
Flags: superreview?(bzbarsky)
Attachment #158160 -
Flags: review?(bzbarsky)
Comment 6•20 years ago
|
||
> (1) why parsing style attributes in XBL involves serialization Binding instantiation is done by doing a deep CloneNode() on the binding's content. Both nsXULElement::CloneNode and nsGenericElement::CopyInnerTo effectively do a GetAttr() followed by SetAttr() for each attribute. Doing that to the "style" attribute serializes and then reparses. > (2) why there wasn't a CSS error when the serialization was reparsed I'm not sure about this one... worth checking out, possibly.
Comment 7•20 years ago
|
||
Comment on attachment 158160 [details] [diff] [review] patch r+sr=bzbarsky
Attachment #158160 -
Flags: superreview?(bzbarsky)
Attachment #158160 -
Flags: superreview+
Attachment #158160 -
Flags: review?(bzbarsky)
Attachment #158160 -
Flags: review+
Assignee | ||
Comment 8•20 years ago
|
||
Fix checked in to trunk, 2004-09-07 22:42 -0700.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking1.8a4?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha4
(In reply to comment #6) > Binding instantiation is done by doing a deep CloneNode() on the binding's > content. Both nsXULElement::CloneNode and nsGenericElement::CopyInnerTo > effectively do a GetAttr() followed by SetAttr() for each attribute. Doing > that to the "style" attribute serializes and then reparses. Wow. There must be a more efficient way to do it.
Comment 10•20 years ago
|
||
> Wow. There must be a more efficient way to do it.
Probably, yes. Even attributes other than style could be more efficient (eg no
need to convert from enums to strings and back).
File a bug on this, perhaps?
Comment 11•20 years ago
|
||
*** Bug 258425 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 12•20 years ago
|
||
I see bug 258451 was filed.
Comment 13•20 years ago
|
||
We could move that style to xul.css or popup.css if you like.
You need to log in
before you can comment on or make changes to this bug.
Description
•