258337 - extension manager nsExtensionsDataSource_addItemMetadata uses wrong array length in a loop

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[(not currently active) Ted Mielczarek]

http://lxr.mozilla.org/aviarybranch/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#3750

3749     var manyProps = ["contributor"];
3750     for (var i = 0; i < singleProps.length; ++i) {
3751       var property = this._emR(manyProps[i]);

3750 uses singleProps.length, when it really means to use manyProps.length.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Use the right array length

Trivial fix.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 158140 [details] [diff] [review]
Use the right array length

It's 1 line.  You know you want to r=.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 158140 [details] [diff] [review]
Use the right array length

diff -u6 at least, -u8 is preferable especially on short patches like this.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 158140 [details] [diff] [review]
Use the right array length

Trivial bugfix, it ought to  make 1.0.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 158140 [details] [diff] [review]
Use the right array length

a=asa for aviary checkin.

Comment 6

[(not currently active) Ted Mielczarek]

Could someone check this in for me?

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 158140 [details] [diff] [review]
Use the right array length

need re-approval now that we're past 1.0 RC. setting back to request.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 158140 [details] [diff] [review]
Use the right array length

too late for 1.0

Comment 9

[(not currently active) Ted Mielczarek]

Patch looks bitrotted on trunk.

Comment 10

[(not currently active) Ted Mielczarek]

Attachment: Updated to trunk [Checkin: See comment 14]

Updated

Comment 11

[Asa Dotzler [:asa]]

Who can review and land this?

Comment 12

[Darin Fisher]

Comment on attachment 177801 [details] [diff] [review]
Updated to trunk
[Checkin: See comment 14]

r=darin

I don't know this code, but clearly if this code is indexing manyProps in the
loop body with i, then i should range from 0 to manyProps.length.

Comment 13

[Benjamin Smedberg]

Please do not land this until Ben's EM rewrite lands.

Comment 14

[Robert Strong (they/them - no direct email)]

This was fixed by the checkin of the patch in bug 291946